Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 401572

Summary: [CBI] 12 Build test failures in CBI builds
Product: [Eclipse Project] PDE Reporter: Curtis Windatt <curtis.windatt.public>
Component: BuildAssignee: Curtis Windatt <curtis.windatt.public>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, pascal
Version: 4.2.2   
Target Milestone: 4.3 M7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 402343    
Bug Blocks:    

Description Curtis Windatt CLA 2013-02-22 16:56:54 EST
http://download.eclipse.org/eclipse/downloads/drops4cbibased/I20130219-0811/testresults/html/org.eclipse.pde.build.tests_linux.gtk.x86_6.0.html#PDEBuildTestSuite

Some are related to the removal of source bundles for branding bundles (Bug 400733).  Others are probably related to problems with the p2 plug-ins.
Comment 1 Curtis Windatt CLA 2013-02-22 17:24:47 EST
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=89521d0c08fcbd58d082e0b880747efb5dbcca07
Fix for test failing because of missing branding source bundle.

The failures in the product tests appear to be related to differences in the delta pack so more investigation is necessary.
Comment 2 Curtis Windatt CLA 2013-02-26 16:29:40 EST
On further investigation, there is a problem when building a product during the tests.  The launcher executable is not getting created.  This causes errors during the p2 tests as touchpoints and other steps can't find the necessary files.

The test console output is not very helpful as errors during ant builds are stored in .log files, but I did see a problem with the platform specific fragments:

!ENTRY org.eclipse.pde.build 2 1 2013-02-19 17:57:50.155
!MESSAGE Some inter-plug-in dependencies have not been satisfied.
!SUBENTRY 1 org.eclipse.pde.build 2 2 2013-02-19 17:57:50.155
!MESSAGE Bundle org.eclipse.equinox.launcher.gtk.linux.x86_64:
	Another singleton version selected: org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20130213-1529

!SUBENTRY 1 org.eclipse.pde.build 2 2 2013-02-19 17:57:50.155
!MESSAGE Bundle org.eclipse.core.filesystem.linux.x86_64:
	Another singleton version selected: org.eclipse.core.filesystem.linux.x86_64_1.2.0.v20120522-1137

!SUBENTRY 1 org.eclipse.pde.build 2 2 2013-02-19 17:57:50.155
!MESSAGE Bundle org.eclipse.core.net.linux.x86_64:
	Another singleton version selected: 
org.eclipse.core.net.linux.x86_64_1.1.0.v20120522-1148

Details on a few tests:

org.eclipse.pde.build.internal.tests.ProductTests.test234032()

This test appears to be failing because the MacOS launcher executable (Eclipse.app) can't be found.  The delta pack looks ok.

org.eclipse.pde.build.internal.tests.ProductTests.testBug192127()

Same as above, looking for Eclipse.app.

org.eclipse.pde.build.internal.tests.ProductTests.testBug269540()

Similar as above, but looking for win32 launcher, rcp.exe
Comment 3 Curtis Windatt CLA 2013-02-26 16:52:39 EST
Doing a normal product export from the UI creates the correct launcher.  However, doing a multi platform export from the UI using the delta pack results in the launcher missing.  Eclipse.exe was missing from Win32 when I am running on Win64.
Comment 4 Curtis Windatt CLA 2013-02-26 17:45:22 EST
Andrew, Pascal, could you help point me in the right direction?  The generated feature for the product includes the correct equinox launcher feature and all the scripts have the correct plug-ins.  I'm missing where the executables from the launcher feature are copied over to the final product.
Comment 5 Curtis Windatt CLA 2013-03-04 10:26:32 EST
The problems in the tests and exporting are because the CBI produced delta pack does not include the build.properties and build.xml in the launcher feature.  See Bug 402343.
Comment 7 Curtis Windatt CLA 2013-03-25 12:54:59 EDT
The executable feature has been updated to include the necessary files.  I have re-enabled the tests.
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=da63be8213cd8b26c57258c12f7bedfa6f8b3b68
Comment 8 Dani Megert CLA 2013-03-26 03:20:46 EDT
Now we get failures in N20130325-2000 again, but not exactly the same on Mac and Linux. Windows 7 results still pending.
Comment 9 Curtis Windatt CLA 2013-03-26 17:03:11 EDT
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=64713ec8995f094c117062daf6267459bf5eefc4
Fix for publishing tests failure.  We assert that motif aix ppc must exist but it is not a supported in the equinox executable feature.

The other failures may represent a real failure, though I don't know what would have changed to cause it.  The launcher is build/copied correctly, but the assemble script is looking in the wrong location (renamed for product export).

Actual build directory:
192127\tmp\eclipse\macosx.cocoa.x86\eclipse\rcp.app\Contents\MacOS 
What assemble script is looking for:
192127\tmp\eclipse\macosx.cocoa.x86\eclipse\Eclipse.app\Contents\MacOS
Comment 10 Curtis Windatt CLA 2013-03-26 17:28:41 EDT
(In reply to comment #9)
> The other failures may represent a real failure, though I don't know what
> would have changed to cause it.  The launcher is build/copied correctly, but
> the assemble script is looking in the wrong location (renamed for product
> export).

Caused by the delta pack build.properties now having:

root.macosx.cocoa.x86=bin/cocoa/macosx/x86
root.macosx.cocoa.x86.permissions.755=Eclipse.app/Contents/MacOS/launcher

root.macosx.cocoa.x86_64=bin/cocoa/macosx/x86_64
root.macosx.cocoa.x86_64.permissions.755=Eclipse.app/Contents/MacOS/launcher

instead of:

root.macosx.cocoa.x86=bin/cocoa/macosx/x86
root.macosx.cocoa.x86.permissions.755=${launcherName}.app/Contents/MacOS/${launcherName}

root.macosx.cocoa.x86_64=bin/cocoa/macosx/x86_64
root.macosx.cocoa.x86_64.permissions.755=${launcherName}.app/Contents/MacOS/${launcherName}

Will reopen Bug 402343
Comment 11 Dani Megert CLA 2013-03-27 04:09:02 EDT
1 is gone but still 3 failures continue in N20130326-2000.
Comment 12 Curtis Windatt CLA 2013-04-04 10:07:52 EDT
With the last change on Bug 402343 the tests now pass.

http://download.eclipse.org/eclipse/downloads/drops4/N20130403-2000/testResults.php