Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 401535

Summary:	Shell page not minified
Product:	[ECD] Orion	Reporter:	Ken Walker <ken_walker>
Component:	Client	Assignee:	Ken Walker <ken_walker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon, simon_kaegi
Version:	3.0
Target Milestone:	3.0 M1
Hardware:	All
OS:	All
Whiteboard:

Description Ken Walker

2013-02-22 09:49:37 EST

There's a walkback in the build log.  I went and built this fine with the r.js version 1.0.7.js vs. the 2.1.4 one

Comment 1 Susan McCourt

2013-02-22 10:20:41 EST

A walkback??????   ;-)
You are at least two languages behind.

Comment 2 Mark Macdonald

2013-04-04 21:17:15 EDT

Hey look, there's already a bug for this open ;). 

The shell page failed to concatenate+minify in recent 3.0M1 builds. Rhino appears to be choking on a regexp somewhere:

updateHTML:
     [copy] Copying 2 files to /shared/eclipse/e4/orion/I201304041705/plugins/org.eclipse.orion.client.ui/web/settings
     [java] 
     [java] Tracing dependencies for: shell/shellPage
     [java] Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 3
     [java] 	at org.mozilla.javascript.regexp.NativeRegExp.parseTerm(NativeRegExp.java:1092)
     [java] 	at org.mozilla.javascript.regexp.NativeRegExp.parseAlternative(NativeRegExp.java:490)
     [java] 	at org.mozilla.javascript.regexp.NativeRegExp.parseDisjunction(NativeRegExp.java:451)
     [java] 	at org.mozilla.javascript.regexp.NativeRegExp.compileRE(NativeRegExp.java:323)
     [java] 	at org.mozilla.javascript.regexp.NativeRegExp.compile(NativeRegExp.java:224)
     [java] 	at org.mozilla.javascript.regexp.NativeRegExpCtor.construct(NativeRegExpCtor.java:88)
     [java] 	at org.mozilla.javascript.ScriptRuntime.newObject(ScriptRuntime.java:2440)
     [java] 	at org.mozilla.javascript.gen._shared_eclipse_e4_orion_requirejs_dist_r_js_1._c_scanRegExp_334(Unknown Source)

Comment 3 Mark Macdonald

2013-04-04 21:19:12 EDT

Possibly related

https://bugzilla.mozilla.org/show_bug.cgi?id=509036

Comment 4 Mark Macdonald

2013-04-11 00:34:59 EDT

I noticed (and fixed) some exceptions about GCLI modules not being found. The build file was missing a bunch of path entries.

But the rhino-choking regex still remains. I'm guessing it's in the GCLI source somewhere, since that changed greatly in this release.

Comment 5 Mark Macdonald

2013-04-11 17:06:28 EDT

Fixed by upgrading Rhino on the build machine. This build has a correctly minified shellPage:
http://download.eclipse.org/orion/drops/I201304111602/