Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 401518

Summary:

[RWT Launcher] Overly large fields in Server Settings group box

Product:

[RT] RAP

Reporter:

Rüdiger Herrmann <ruediger.herrmann>

Component:

Tools

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

ivan

Version:

2.0

Target Milestone:

2.1 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	rsternberg: review+

Description Rüdiger Herrmann

2013-02-22 06:31:37 EST

The 'Fixed port' and 'Session timout' fields are overly wide for the amount of digits they are meant to hold. I suggest to mimit their width to 6 or so digits instead of using the excess space.

Comment 1 Ivan Furnadjiev

2013-02-22 07:37:15 EST

Even, I can't find spinners in other launchers/tabs, I think that the width of the 'Fixed port' and 'Session timeout' sninners is consistent with the width of all other text-based controls (texts, combos...) in all the launchers/tabs.

Comment 2 Rüdiger Herrmann

2013-02-22 08:28:08 EST

(In reply to comment #1)
> Even, I can't find spinners in other launchers/tabs, I think that the width
> of the 'Fixed port' and 'Session timeout' sninners is consistent with the
> width of all other text-based controls (texts, combos...) in all the
> launchers/tabs.
The other fields are meant to hold potentially long content like project/class/file names. 'Fixed Port' and 'Session Timeout' aren't, the maximum length of their content is no more than six or so characters. 
I would weight the fit of these fields for their use heigher than the consistency with the length of the remainig fields.

Comment 3 Ralf Sternberg

2013-03-06 05:58:11 EST

I found this statement in the Gnome HI guidelines, so I guess you're right ;-)

"Size text entry fields according to the likely size of the input. This gives a useful visual cue to the amount of input expected, and breaks up the dialog making it easier to scan. Don't make all the fields in the dialog the same width just to make everything line up nicely."

What about putting the two spinners side-by-side then and save some vertical space instead of leaving an unused gray area on the right?

Comment 4 Rüdiger Herrmann

2013-03-06 06:19:45 EST

(In reply to comment #3)
> [ ... ]
> What about putting the two spinners side-by-side then and save some vertical
> space instead of leaving an unused gray area on the right?
Sounds good to me

Comment 5 Ivan Furnadjiev

2013-03-06 06:21:36 EST

+1

Comment 6 Ivan Furnadjiev

2013-05-21 09:21:01 EDT

Created attachment 231253 [details]
Proposed patch

This patch puts the two spinners side-by-side as suggested in comment#3 for both RAP and RWT launcher.

Comment 7 Ralf Sternberg

2013-05-21 15:51:34 EDT

With this patch, the fields are misaligned on the left. For me that doesn't look perfect. Maybe we should try a 4-column grid then?

Comment 8 Ivan Furnadjiev

2013-05-22 02:00:35 EDT

Created attachment 231291 [details]
Proposed patch

(In reply to comment #7)
> With this patch, the fields are misaligned on the left. For me that doesn't look
> perfect. Maybe we should try a 4-column grid then?
Four columns patch that fixes the context path text field indentation.

Comment 9 Ralf Sternberg

2013-05-22 03:57:32 EDT

Comment on attachment 231291 [details]
Proposed patch

This patch looks much better. I'd suggest to reduce the 50px indentation of the 2nd checkbox to 25px.

Comment 10 Ivan Furnadjiev

2013-05-22 04:05:55 EDT

Applied patch to master with commit aebda60c8b5a21bfffb9a3dd6d351036e2db60df and reduced the indent to 25px as suggested in comment#9.