Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 401260

Summary: Git Credentials area missing update and delete if checked off
Product: [ECD] Orion Reporter: Ken Walker <ken_walker>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 2.0Flags: susan: review+
ken_walker: review+
Target Milestone: 2.0 RC3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Just showing what it did look like to Mark none

Description Ken Walker CLA 2013-02-19 23:06:34 EST
I checked off the 'remember git credentials' box then went to checkout some items from GitHub.  It wasn't working correctly so I went to undo my saves but there's no list of the repositories I'd remembers and I cannot find an Update button if I toggle off the 'remember git credentials' box.

Can someone else have a go at this to see if it's repeatable in RC3?
Comment 1 Ken Walker CLA 2013-02-20 11:22:21 EST
Created attachment 227341 [details]
Just showing what it did look like to Mark
Comment 2 Mark Macdonald CLA 2013-02-20 11:26:06 EST
I broke this while de-dojoifying the LabeledCommand

Proposed fix is in origin/bug401260:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c4a118e72c823dc1848fd817e58ee178acc00868
Comment 3 Ken Walker CLA 2013-02-20 11:50:18 EST
Tested by cherry picking this commit and now the list is back and the update button is back.  Thanks.
Comment 4 Susan McCourt CLA 2013-02-20 13:33:49 EST
+1.
For me, the update button was always there, but the repository was not.
Verified the fix and checked the code.