Bugzilla – Full Text Bug Listing
| Summary: | Weird parameter collector popup layout | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> | ||||||
| Component: | Client | Assignee: | Susan McCourt <susan> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ken_walker, simon_kaegi, susan | ||||||
| Version: | 2.0 | Flags: | Szymon.Brandys:
review+
simon_kaegi: review+ |
||||||
| Target Milestone: | 2.0 RC3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 227199 [details]
Screenshot
I've got a proposed fix, can you review the source and also try it for your case? It does two things: 1) parents the input box with the label and sets "no-wrap" to the label 2) adds a span for the "dismiss" section (More/Submit/Close) that right-aligns on a separate line. Slideouts already have a right-aligned dismiss section, but the auto-generated popups did not. This produces a nicer layout in other parameter popup dialogs such as the "create new content" buttons. But please test the effect for your particular case. I can't get into too much restyling here because the slideouts also rely on this code path. Commit is http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=bug401083&id=6c5e28087f9454f8bbafbba49276dcb19e180932 remote branch is bug401083. Simon and Ken: heads up. Potential RC3 fix. Szymon needs to review/test the behavior first. Created attachment 227258 [details]
The same popup after the fix
It looks better now.
great. Szymon, can you +1 it. Ken/Simon: ok for RC3? I looked at it and it's good to commit. pushed commit. |
My parameter description is: new mCommands.ParametersDescription( [new mCommands.CommandParameter("currentChangeSet", "boolean", 'Current:'), new mCommands.CommandParameter("changeSetComment", "text", 'Change Set Comment:')]); And the popup looks like on the attached screenshot. Can we have it fixed for RC3?