Bug 400523

Description Shea Tomsin 2013-02-12 01:27:55 EST

Created attachment 226896 [details]
IDE Editor

void method flagged with 'potential resource leak' warnings (see setValue) but adding an empty return (see setValueReturn) satisfies IDE.

Appears related to bug 383779 but that bug involves a for loop example and has a comment 'removing the for loop from my sample makes the warning go away'.  There is no loop in this example.

Appears related to bug 360910 but that bug involves re-throwing the exceptions; this example sinks exceptions.

I apologize in advance for submitting a duplicate bug should this be determined a duplicate.

----------------------------------

package com;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;

public class LeakWarning {
	String value = null;
	
    public void setValue(Connection conn)
	{        
        PreparedStatement stmt = null;
        ResultSet rs = null;
        try {            
            stmt = conn.prepareStatement("SELECT 'value'");  /* marked as potential resource leak */
            rs = stmt.executeQuery();                        /* marked as potential resource leak */
            if (rs.next()) value = rs.getString(1);
        } catch(SQLException e) {
        }
        finally {
        	if (null != rs)   try { rs.close();   } catch (SQLException e) {} finally { rs = null;   }
        	if (null != stmt) try { stmt.close(); } catch (SQLException e) {} finally { stmt = null; }
        }
    }
    
    public void setValueReturn(Connection conn)
	{        
        PreparedStatement stmt = null;
        ResultSet rs = null;
        try {            
            stmt = conn.prepareStatement("SELECT 'value'");
            rs = stmt.executeQuery();
            if (rs.next()) value = rs.getString(1);
        } catch(SQLException e) {
        }
        finally {
        	if (null != rs)   try { rs.close();   } catch (SQLException e) {} finally { rs = null;   }
        	if (null != stmt) try { stmt.close(); } catch (SQLException e) {} finally { stmt = null; }
        }
        return; /* no warning now */
    }
}