Bugzilla – Full Text Bug Listing
| Summary: | "Compare with working tree" action in git log page is not working. | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | libing wang <libingw> |
| Component: | Git | Assignee: | Project Inbox <orion.git-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Szymon.Brandys |
| Version: | 1.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |
I noticed this when trying the selection model in all pages. I happened to try "Compare with working tree" action in git log page, although it is not used as my regular work flow. I found that compareWithWorkingTree command in gitCommands.js is not passing a good diff URL to compare widget. The data.items.DiffLocation could not resolve the two file URLs as the compareGitCommits command does. By the way, another alternative is to pass the two file URLs to the compare widget. The widget will resolve diff on client side. mCompareUtils.generateCompareHref(theURLOfTheCommit, {compareTo: the URLOnWorkingTree, readonly: true}). The mCompareUtils.generateCompareHref function will just generate a compare URLtemplate, where the "compareTo" property in the URLTemplate represent the file URL that will be rendered on the right side of the compare widget.