| Summary: | [Import/Export] Project import wizard does not remember selected folder or archive | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Christian Georgi <christian.georgi> | ||||||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | daniel_megert, helmut.haigermoser | ||||||||
| Version: | 4.3 | ||||||||||
| Target Milestone: | 4.3 M6 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Christian Georgi
Created attachment 226809 [details]
Stores project and archive location persistently
If we start to remember the location, then we should do it the same as in the other import/export dialogs, where we present the previous values in a combo box. See org.eclipse.ui.internal.wizards.datatransfer.WizardArchiveFileResourceExportPage1.internalSaveWidgetValues() for an example. Also, we use IDialogSettings instead of preferences to remember previous locations. PW I have updated WizardProjectsImportPage accordingly, i.e. replaced the Text fields with Combos and used IDialogSettings instead of preferences. In order to make use of the existing combo history infrastructure, the page now extends WizardDataTransferPage. This also removes some code redundancies (see queryOverwrite()). Created attachment 226971 [details]
Updated patch
Created attachment 226972 [details]
mylyn/context/zip
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=21121bd72dc7c1a271ccb9d681ba4a0ded7b44bc Thanks Christian. PW I didn't do a code review, but the functionality works fine. I updated the copyright notice. *** Bug 365930 has been marked as a duplicate of this bug. *** |