Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 400355

Summary: Server shouldn't generate markdown-formatted URLs
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: NodeAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: libingw
Version: 2.0Flags: libingw: review+
Target Milestone: 2.0 RC2   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Mark Macdonald CLA 2013-02-08 13:26:11 EST 
I noticed that when the server returns a JSON object giving the information about an app that is being debugged, it generates a DebugURL field using this code:

> return "[" + debugURL + "](" + debugURL + ")";

Which produces something like this
> "DebugURL": "[http://localhost:8900/debug?port=5860](http://localhost:8900/debug?port=5860)"

The formatting of URLs as markdown-type links is not something the server should know about. It should return a plain old URL, and the nodePlugin (the part that actually connects to the the Orion shell) should do any formatting that is necessary.
Comment 1 Mark Macdonald CLA 2013-02-08 16:17:49 EST 
Proposed fix is in a branch: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=node_linkify
Comment 2 libing wang CLA 2013-02-11 13:03:36 EST 
Yes, Agree.
I reviewed the patch. Looks good to me.
Comment 4 Mark Macdonald CLA 2013-02-11 14:25:34 EST 
^