Bugzilla – Full Text Bug Listing
| Summary: | Unexternalized strings on UI Theme and Editor Theme pages | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Kit Lo <kitlo> | ||||||||||||
| Component: | Client | Assignee: | Michael Rennie <Michael_Rennie> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | curtis.windatt.public, keithc, malgorzata.tomczyk, mamacdon, Michael_Rennie, Silenio_Quarti, simon_kaegi | ||||||||||||
| Version: | 2.0 | ||||||||||||||
| Target Milestone: | 7.0 | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows XP | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 226917 [details]
Theme Selection
Strings in theme selection popup in editor are unexternalized. Are they using the same strings from the settings page?
As far as I can tell, all of the editor/theme related settings are NLS'd correctly in the following two files. Please reopen if any have been missed. bundles / org.eclipse.orion.client.ui / web / orion / widgets / settings / EditorSettings.js bundles / org.eclipse.orion.client.ui / web / orion / settings / nls / root / messages.js Created attachment 246045 [details]
Theme names.png
Curtis, most of the strings reported above are now externalized, except the theme names. I imagine some countries may want to translate the theme names like "Green Zone", "Red".
reopen Externalized theme names: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=513e60716ac0171dd8eea48d95631aab48f28f7c Michael, I downloaded Orion server I20140826-0218, cleared all browser cache, cleared all local storage, deleted the server workspace. Installed a language pack with the theme names translated. However, the dropdown list is still showing the theme names in English. Can you investigate? Looks like (In reply to Kit Lo from comment #6) > Michael, I downloaded Orion server I20140826-0218, cleared all browser > cache, cleared all local storage, deleted the server workspace. Installed a > language pack with the theme names translated. However, the dropdown list is > still showing the theme names in English. Can you investigate? Fixed in: http://git.eclipse.org/cgit.cgi/orion/org.eclipse.orion.client.git/commit/?id=f2387f84ebaf88f67605cedfbafadcfd475b9fe3 Michael, those editor themes you just fixed in comment 7 were indeed unexternalized. Almost forgot about that. However, for the windows themes your fixed earlier, we had them translated, generated language packs, cleared all browser cache, cleared all local storage, deleted the server workspace, launched the latest server. However, we still did not see the translations loaded. Not sure why. As I mentioned to Kit via email: The trouble in Comment 8 likely happens because theme names (like all theme data) get cached in localStorage. If an English translation is loaded when you first land on the Settings page, the English names will persist, even after installing another language pack. So to observe the translated theme names, you have to follow this order of steps: 1. Install Orion UI language pack plugin for your language 2. Clear localStorage 3. Go to the Settings page, click UI Theme This should display the translated names from the language pack. (In reply to Mark Macdonald from comment #9) > As I mentioned to Kit via email: > > The trouble in Comment 8 likely happens because theme names (like all theme > data) get cached in localStorage. If an English translation is loaded when > you first land on the Settings page, the English names will persist, even > after installing another language pack. > > So to observe the translated theme names, you have to follow this order of > steps: > 1. Install Orion UI language pack plugin for your language > 2. Clear localStorage > 3. Go to the Settings page, click UI Theme > > This should display the translated names from the language pack. Verified in 7.0.0.v20140904-0231, I'm able to see the strings are mocked now. will keep you updated if the translations can be picked up correctly. Created attachment 246753 [details]
400232_fixed_7.0.0.v20140904-0231
(In reply to Keith Chuang from comment #10) > (In reply to Mark Macdonald from comment #9) > > As I mentioned to Kit via email: > > > > The trouble in Comment 8 likely happens because theme names (like all theme > > data) get cached in localStorage. If an English translation is loaded when > > you first land on the Settings page, the English names will persist, even > > after installing another language pack. > > > > So to observe the translated theme names, you have to follow this order of > > steps: > > 1. Install Orion UI language pack plugin for your language > > 2. Clear localStorage > > 3. Go to the Settings page, click UI Theme > > > > This should display the translated names from the language pack. > > Verified in 7.0.0.v20140904-0231, I'm able to see the strings are mocked > now. will keep you updated if the translations can be picked up correctly. The translations can be loaded now, thank you very much! Hi Kit, Would you please help update the status accordingly? Thank you. Created attachment 246881 [details]
400232_fixed_translations
|
Created attachment 226710 [details] Editor Theme Unexternalized strings on UI Theme and Editor Theme pages