Bugzilla – Full Text Bug Listing
| Summary: | implement Gerrit Remote API | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Miles Parker <milesparker> |
| Component: | Mylyn | Assignee: | Miles Parker <milesparker> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | sebastien.dubois, steffen.pingel |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | Macintosh | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
| Bug Depends on: | 400167, 400356, 402792, 406036 | ||
| Bug Blocks: | |||
|
Description
Miles Parker
See bug 400270 comment 9 and https://git.eclipse.org/r/#/c/11012/ to show how we'll leverage the API. Please review https://git.eclipse.org/r/#/c/11012. •Improve Remote API, separating consumer and observer concerns •Remote API now fully decouples remote access from UI •Editor and navigator interactions are now fully synchronized •Implement changes for Gerrit Remote API •Update Gerrit ChangeDetailX •Implement additional Gerrit Remote Factories applications •Fix update bugs affecting patch set and review detail sections •Additional testing Note that this is another 3k line wonder. Sorry, I *really* tried to separate things out more, but beyond removing the model stuff I couldn't find any opportunities. The Remote API changes are signficant in themselves, and I had to make the Gerrit implementation changes to match the Remote API so that the thing would build. All of this includes both model and UI components which aren't separable. Finally, main drivers for these improvements are updating issues such as bug 404470 and bug 404470 and the desire to remove all Gerrit Remote calls from the UI itself. It seems silly to make all of these changes without actually including the improvements that they facilitate.. That said, I'm open to ideas for breaking this down more. :) Thanks Miles. I'll bootstrap on the latest of https://git.eclipse.org/r/#/c/11012/. I'm seeing some occasional issues with the ReviewNavigator missing remote notifications from patch set openings. Investigating that. (In reply to comment #4) > I'm seeing some occasional issues with the ReviewNavigator missing remote > notifications from patch set openings. Investigating that. I have a fix for those issues. I'm working on getting comments within a patch set to update properly and when I have that (prob. tmrw) I'll upload a new change for both. Miles, what's still left to do here? We still have to do the push side :). bug 406036 Miles, what is left to do here? "We still have to do the push side :)." This isn't needed for any planned 2.0 functionality, so let's push it off until just after Kepler. Marking as complete as we have decided that push API is no longer needed / in scope. |