Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399977

Summary: [Text][Combo] Vertical alignment in text fields not working in IE7 and 8
Product: [RT] RAP Reporter: Tim Buschtoens <tbuschto>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: tbuschto
Version: 2.0Flags: tbuschto: review?
Target Milestone: 2.0   
Hardware: All   
OS: All   
Whiteboard:

Description Tim Buschtoens CLA 2013-02-05 08:54:45 EST
In RAP 2.0 RC2 and RAP master the vertical alignment for text fields is broken.
This is due to some of the client changes back in december. Since the Text field is mostly qooxdoo code, it's barely tested, so it didn't break any tests and nobody noticed the visual changes apparently.
Comment 1 Tim Buschtoens CLA 2013-02-05 09:16:34 EST
Fixed in master with commit e2d9d2a5a7a2d47c56b5cb76f1f5aadfa09b3ae6. I put the new client.js in a separate commit to easy cherry-picking for the 2.0 branch. Please review commit for 2.0 branch.
Comment 2 Ivan Furnadjiev CLA 2013-02-05 09:19:44 EST
+1 i think it's a safe fix
Comment 3 Ralf Sternberg CLA 2013-02-05 09:42:40 EST
+1 It's an obvious typo. Let's apply it to the 2.0 maintenance branch.
Comment 4 Tim Buschtoens CLA 2013-02-05 11:20:42 EST
Applied to 2.0 (commit 1dbb513d7f0214a70e852cc1470054fc077575d0) and rebuild client.js (commit 2eb3a2c6043a065e2e550858d8a9a8b62fcc14b7)