Bugzilla – Full Text Bug Listing
| Summary: | editor.util should be removed | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Editor | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Silenio_Quarti |
| Version: | 2.0 | ||
| Target Milestone: | 4.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
(In reply to comment #0) > The bind shim should be moved to another file and consumed separately > (perhaps es5shim can be resurrected in the editor bundle). Assuming the shim is still necessary, that is. I'm not certain if Editor needs to run in non-ES5 browsers. Released changes that stop exporting util for now: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2dcf5996cf50b593e648dacc35f18f563988d022 Function.bind has been moved to shim.js and is not include in the Orion build (Orion only supports browsers with ECMAScript 5). It is included in the standalone editor as we want to support IE8 (see bug#416933). |
Currently editor.js exports Editor and 'util' > return { > Editor: Editor, > util: { > bind: bind > } > }; util is not useful, it just contains a shim for Function.bind. It should be removed so that Editor is the only export. The bind shim should be moved to another file and consumed separately (perhaps es5shim can be resurrected in the editor bundle).