Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399891

Summary:	Sites Page broken in latest build
Product:	[ECD] Orion	Reporter:	Ken Walker <ken_walker>
Component:	Releng	Assignee:	Ken Walker <ken_walker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	mamacdon
Version:	2.0
Target Milestone:	2.0 RC1
Hardware:	All
OS:	All
Whiteboard:

Description Ken Walker

2013-02-04 09:17:30 EST

I deployed the 2013-02-03 build and then discovered that the sites pages does not come up at all.  Had to revert back to the 31st.

Comment 1 Ken Walker

2013-02-04 09:30:25 EST

Hmm, self hosting seems fine - will download and try the build locally

Comment 2 Ken Walker

2013-02-04 09:37:21 EST

Download exhibits the problem - sites page is non-functional

Comment 3 Mark Macdonald

2013-02-04 10:01:34 EST

The built-sites page is missing entire modules. Here's the list of what it's missing (taken from the 0.2M2 build log)

>      [java] orion/i18n!orion/sites/nls/messages
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/nls/messages.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/nls/root/messages.js
>      [java] i18n!orion/sites/nls/messages
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/siteClient.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/treeModelIterator.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/explorers/explorerNavHandler.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/section.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/webui/treetable.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/explorers/explorer.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/siteUtils.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/siteCommands.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././orion/sites/sitesExplorer.js
>      [java] /opt/public/eclipse/e4/orion/I201301272230/optimization/././sites/sites.js

Somehow it even managed to omit the "sites" module from the built version of "sites"!

Comment 4 Mark Macdonald

2013-02-04 10:36:14 EST

(In reply to comment #3)
This wasn't quite right. Some of the dependencies are just in a different order. The correct list of missing modules is

>      [java] /opt/public/eclipse/e4/orion/xxx/optimization/././orion/sites/siteCommands.js
>      [java] /opt/public/eclipse/e4/orion/xxx/optimization/././orion/sites/siteUtils.js
>      [java] /opt/public/eclipse/e4/orion/xxx/optimization/././orion/sites/sitesExplorer.js
>      [java] /opt/public/eclipse/e4/orion/xxx/optimization/././sites/sites.js

Comment 5 Mark Macdonald

2013-02-05 10:30:55 EST

The build process used a 1.0 version of requirejs to concatenate and minify each page. Apparently that version had a bug that made it omit certain dependencies -- we found built-edit.js having a similar problem as built-sites.

Upgrading to requirejs 2.x seems to have fixed it.