Bugzilla – Full Text Bug Listing
| Summary: | Many broken shortcuts in multi-page editors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Grzegorz Grzybek <gr.grzybek> | ||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | blocker | ||||||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert, david_williams, emoffatt, ian.trimble, john.arthorne, thatnitind, vrubezhny | ||||
| Version: | 4.2.1 | Flags: | daniel_megert:
pmc_approved+
john.arthorne: pmc_approved+ emoffatt: review+ |
||||
| Target Milestone: | 4.2.2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=426557 | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 399396, 399457 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Grzegorz Grzybek
Do the key bindings work in Text and Java editors? Yes - they do. Even HTML editor (which is closer to WTP than Java Editor IMO) works fine. Just XML Editor is broken. I have M2E (+M2E-WTP) and neither M2E opened XMLs not standard XML Editors don't work. Also, I have several key binding conflicts, but they don't include ALT+Up: !MESSAGE A conflict occurred for ALT+SHIFT+ARROW_UP: Binding(ALT+SHIFT+ARROW_UP, ParameterizedCommand(Command(org.eclipse.wst.sse.ui.structure.select.enclosing,Select Enclosing Element, Expand selection to include enclosing element, Category(org.eclipse.ui.category.edit,Edit,null,true), org.eclipse.ui.internal.MakeHandlersGo@4daa3d77, ,,true),null), org.eclipse.ui.defaultAcceleratorConfiguration, org.eclipse.wst.sse.ui.structuredTextEditorScope,,,system) Binding(ALT+SHIFT+ARROW_UP, ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.select.enclosing,Select Enclosing Element, Expand selection to include enclosing element, Category(org.eclipse.ui.category.edit,Edit,null,true), org.eclipse.ui.internal.MakeHandlersGo@32c00f48, ,,true),null), org.eclipse.ui.defaultAcceleratorConfiguration, org.eclipse.jdt.ui.javaEditorScope,,,system) I've just reverted to 4.3.0.I20121214-073 and shortcuts in XML Editors work fine.. I assume you already verified this, but just to be sure: - there is only one command for e.g. 'Delete Line' on the 'Keys' preference page - Ctrl+D is only used once on the 'Keys' preference page Actually - no (neither in 4.3m4 nor in 4.3m5) - there's also CTRL-D for "Delete line" in "Embedded Xtext Editor context" - but that's not a problem in 4.3m4. Thanks for looking into it ;) Thanks for reporting this bug! Many key bindings for the XML Editor are broken when installing it on top of M5 or our latest Juno SR 2 candidate. The problem got introduced with the fix for bug 399396. Test Case: 1. start new workspace 2. install 'Eclipse XML Editors and Tools' from the Juno repository 3. create an XML file with some content 4. try e.g. Ctrl+D to delete a line As far as I can see, there is no workaround. Paul, if you think there's a safer and better way than to just revert the two changes for now, please add a new patch that can be tested. OK, looking at it now. PW Created attachment 226508 [details] Use the correct partSite The problem was our new handler expression was using the MultiPageEditorSite as the part site, but the MPES is never exposed to the expression subsystem. In 3.x they also had a step where the parent KeyBindingService (the one for the editor, like XMLEditorPart) went through and actually replaced the inner part submissions to use its own workbenchPartSite. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/KeyBindingService.java?h=R3_8_maintenance#n438 This fix uses the correct EditorSite when creating the submissions in the first place, and CTRL+D functions again. PW (In reply to comment #12) Thanks for the quick response Paul! > In 3.x they also had a step where the parent KeyBindingService (the one for > the editor, like XMLEditorPart) went through and actually replaced the inner > part submissions to use its own workbenchPartSite. > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org. > eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/KeyBindingService. > java?h=R3_8_maintenance#n438 Right, I can remember that part now. Sorry I didn't see this when I reviewed the original fix last week. Comment on attachment 226508 [details] Use the correct partSite I reviewed the patch and verified that it works. I also verified that the original bug 399396 is still fixed. It is also reproducible using the Eclipse SDK. Open a PDE manifest editor and try Ctrl+D in the MANIFEST.MF pane (raw text view). (In reply to comment #15) > It is also reproducible using the Eclipse SDK. Open a PDE manifest editor > and try Ctrl+D in the MANIFEST.MF pane (raw text view). Yes, I already updated the summary. All multi-page editors are affected. Eric, please review this patch. PW +1 to fix this in Juno SR2 RC4 and re-spin M5. As far as it goes the patch looks OK... As some point we're going to have to make this while layer deterministic (which it is demonstrably not ATM). I've released this as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=76dc3c2a1bb13d10c83dd74ed777fd84e67cd60b and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=671819c88882506b6e67414c63c808c31ee5de49 Sorry about that. PW +1 The fix in master fixes the shortcuts in the PDE editors. I have disabled all repos in 'tagging' except for platform.ui (at Dani's suggestion, in case others have started on M6 already) http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/?id=f2b0bc37841ea6d32dbbe2c31cd0d7b8fb897ebc And scheduled the a re-build to start at 2 PM Eastern, today. (Monday, 2/4). (In reply to comment #22) > I have disabled all repos in 'tagging' except for platform.ui (at Dani's > suggestion, in case others have started on M6 already) > > http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/ > ?id=f2b0bc37841ea6d32dbbe2c31cd0d7b8fb897ebc > I've reverted this change to repositories.txt, so nightly and tomorrow's I-build should be normal builds towards M6. The "changed" record sent in email may look funny, since it should mention something about reverting this bug (and not sure it capture my full comment about commenting out other repositories). Thanks for great work! If only WTP team could fix 323157 (see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=323157#c7) that fast... I've posted full analysis (and I'm using my patched version of org.eclipse.wst.wsi_1.0.500.v201203081939.jar for 3 months now) of the simple problem there... regards Grzegorz Grzybek Verified in 4.2-M20130204-1200 and I20130204-1400 (4.3 M5a). Thanks. I20130204-1400 works great! *** Bug 400354 has been marked as a duplicate of this bug. *** *** Bug 400372 has been marked as a duplicate of this bug. *** |