Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399753

Summary:	Disappearing command slideout
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	susan
Version:	2.0
Target Milestone:	2.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-02-01 14:01:09 EST

I20130131-2230 @ orion.eclipse.org

Go here:
1. https://orion.eclipse.org/settings/settings.html#,category=plugins,installPlugin=http://localhost:8080/plugins/nonnlsPlugin.html
2. You should see a slideout showing the plugin URL and offering a Submit button

If I wiggle the mouse cursor around the slideout for a moment or two, the slideout eventually disappears (kind of like a tooltip would). That shouldn't happen.

Comment 1 Susan McCourt

2013-02-02 15:12:36 EST

The real problem here is that it's not a real slideout, it's an autogenerated popup dialog.  (ie, it's a tooltip dialog, not the dark slideout.)

The dark slideout is intentionally set up to stay put until you dismiss it, whereas the little popup dialogs do not.  So anything bound with a URL should be using the toolbar slideout.

I think this must have broken somehow during either the settings page refactoring or command rework.  That little popup comes up when a slideout can't be found.

I'll investigate Monday.

Comment 2 Susan McCourt

2013-02-02 23:38:40 EST

fixed with 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=17b0623ece7c8b9413d4a6633a82551e5f78976c

The problem was that a slideout was being created, but the document fragment was not being parsed.  You can't set innerHTML on a document fragment.  I changed it to create a range and parse the HTML to the range node.  This is what we do elsewhere.

http://stackoverflow.com/questions/8202195/using-document-createdocumentfragment-and-innerhtml-to-manipulate-a-dom

For some reason git.eclipse.org can't show this commit link but I verified that the right code is in master.