Bugzilla – Full Text Bug Listing
| Summary: | Only one editor plugin is fired | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | simon_kaegi |
| Version: | 1.0 | ||
| Target Milestone: | 2.0 RC1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Ken Walker
Which one appears first (left to right)? JsBeautify I'm guessing. If the quote plugin appears last then I suspect it's the #*&#$(*@ infamous wrong binding of a loop variable and I will kneel before the coding convention gods, admit my transgressions and switch to forEach. I thought I had grown out of that kind of bug. If the quote plugin appears first than I'm not sure that's it, but I'll take a look regardless. There is a sinner on line 376 (and referenced on 390) of editorCommands.js that can only be healed by a true believer in forEach... fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=871803aa11152c362a2ab9612e1883aeda3a2e80 As penance and proof of my coding convention loyalty I also fixed all jslint errors, externalized two previously untranslated and wrongfully concatenated messages, and cleaned up all jslint warnings except for the "better in dot notation" message key warning. Ken mentioned yesterday (Friday) that it didn't seem to work. I just tested ide.css with "toRGB" and "UPPER" installed, and it seems to work. So I think it could have been a problem with the plugin Ken was using. Or else there's a more subtle case. Ken, can you double check? |