Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399291

Summary:	JME in Javadoc hover in compare editor (old Git version)
Product:	[Eclipse Project] JDT	Reporter:	Markus Keller <markus.kell.r>
Component:	Text	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, markus.kell.r
Version:	4.3
Target Milestone:	4.3 M5
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Markus Keller

2013-01-28 13:25:25 EST

I20130122-0800

- close all editors
- open a Java editor for a file from a Git repo
- select an older revision in the History view and choose Compare with Workspace
- hover over a method or field declaration in the right side of the compare editor
=> Javadoc hover says an exception occurred.


Java Model Exception: Java Model Status [<project root> [in  ] is not on its project's build path]
	at org.eclipse.jdt.internal.core.JavaElement.newJavaModelException(JavaElement.java:508)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:246)
	at org.eclipse.jdt.internal.core.JavaElement.openWhenClosed(JavaElement.java:521)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:258)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:244)
	at org.eclipse.jdt.internal.core.PackageFragmentRoot.getKind(PackageFragmentRoot.java:481)
	at org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations.getExplanationForMissingJavadoc(JavaDocLocations.java:647)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.getHoverInfo(JavadocHover.java:651)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.internalGetHoverInfo(JavadocHover.java:567)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.getHoverInfo2(JavadocHover.java:559)
	at org.eclipse.jdt.internal.ui.text.java.hover.BestMatchHover.getHoverInfo2(BestMatchHover.java:163)
	at org.eclipse.jdt.internal.ui.text.java.hover.BestMatchHover.getHoverInfo2(BestMatchHover.java:129)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaEditorTextHoverProxy.getHoverInfo2(JavaEditorTextHoverProxy.java:85)
	at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166)

Comment 1 Markus Keller

2013-01-28 13:28:13 EST

Manju, please check if we did show a Javadoc hover in 4.2 in this case, and propose a fix that at least avoids the JME (or better yet: makes the hover work).

Comment 2 Dani Megert

2013-01-29 02:32:49 EST


*** This bug has been marked as a duplicate of bug 397447 ***

Comment 3 Dani Megert

2013-01-29 09:52:43 EST

Actually, the problem got introduced again.

Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9dbbfa2f7d38d37dfa9ba067c22d84aa5bedb6ec

Comment 4 Dani Megert

2013-01-29 09:52:57 EST

Comment 5 Dani Megert

2013-01-30 05:03:50 EST

Verified in I20130129-2000.