Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399263

Summary:

[1.8][compiler][internal] Turn MethodVerifier15.doesMethodOverride into a static method.

Product:

[Eclipse Project] JDT

Reporter:

Srikanth Sankaran <srikanth_sankaran>

Component:

Core

Assignee:

ANIRBAN CHAKRABORTY <anchakrk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

4.3

Target Milestone:

BETA J8

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

399224

Attachments:

Description	Flags
Untested patch from Anirbhan	none

Description Srikanth Sankaran

2013-01-28 08:59:40 EST

BETA_JAVA8: 

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=399224#c2
    https://bugs.eclipse.org/bugs/show_bug.cgi?id=399224#c3
    https://bugs.eclipse.org/bugs/show_bug.cgi?id=399224#c4

Comment 1 Srikanth Sankaran

2013-01-29 22:56:58 EST

Created attachment 226292 [details]
Untested patch from Anirbhan

[Please use bugzilla to attach patches. Discussion on work in progress
should be on bugzilla]

Comment 2 Srikanth Sankaran

2013-01-30 00:16:38 EST

Some comments/meta comments:

1. Patches should always be generated after synching with the repository so
they cleanly apply. The present patch fails to apply.

2. A patch should not contain extraneous changes, noise diffs, needless
formatting changes etc. The present patch contains changes to ReferenceBinding,
TypeBinding, ProblemReasons etc which are not relevant at all.

3. We don't want to leave in stale code in comment blocks. Where they are
really useless, let us get rid of them.

4. MethodVerifier#computeSubstituteMethod(MethodBinding inheritedMethod, MethodBinding currentMethod) should not have been retained at all !!!
MethodVerifier15's computeSubstituteMethod is pulled up a static method
with an extra argument, so calls through instances will bind to
1.4 behavior which would be wrong !

5. All modified files should reflect updated copyright.

I have made these changes and the tests are green. I'll post a patch
shortly.

Comment 3 Srikanth Sankaran

2013-01-30 00:21:23 EST

Fix released via http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA8&id=5deead051fd76da1bc6ad122fc16f2ab2fddd2ef. Thanks Anirbhan
for your first fix.