Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 399262

Summary: Search: clicking on the options causes the main pane drift.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: susan
Version: 1.0   
Target Milestone: 2.0 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2013-01-28 08:53:26 EST
Type a search word in the search box and it brings yo uto the search result page. Click on the options and you will find that the main pane drifts to the left, leaving a empty area on the right.
Comment 1 libing wang CLA 2013-01-28 08:57:01 EST
Susan, I could be wrong but my gut feeling is that the options popup and the main pane have the some parent DIV, causing the parent to expand.
Comment 2 Susan McCourt CLA 2013-01-29 17:14:56 EST
(In reply to comment #1)
> Susan, I could be wrong but my gut feeling is that the options popup and the
> main pane have the some parent DIV, causing the parent to expand.

I'll take a look, that could be true.
Comment 3 Susan McCourt CLA 2013-02-06 01:29:05 EST
The new actions menu in the projects drive list has similar positioning problems.  Investigating next...
Comment 4 Susan McCourt CLA 2013-02-07 14:13:43 EST
Fixed with
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=77f17ce598991b0b985ee16c2c4152ac5a4e7c01

This was really just a slightly better fix for what was done in bug 395969 comment 1.  The original commit shifted the menu's style left which can be impacted by layering of parents and positions absolute/relative.  
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=783d3271e9604a328ff57589d6ff0245ccb8b696

Instead we need to detect the menu is off screen and just set the right to 0 to pin it to the right edge.  Checked the various cases on IE10, Chrome, FF and these menus are still positioning right:

- user menu
- related menu
- outliner menu
- actions menu on projects page
- search options menu
- find slideout menu
- nav actions menu

As stated in bug 395969, this doesn't adjust submenus, but I think for now we should keep the code simpler and have clients include a submenu left CSS when needed.
Comment 5 Susan McCourt CLA 2013-02-07 14:13:58 EST
.