Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 398990

Summary:	[QuickAccess] SearchField should create shell and listener in order
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Rene.Brandstetter
Version:	4.2.1
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	stalebug

Description Paul Webster

2013-01-24 12:00:38 EST

The search field adds a listener that uses a shell, restores its dialog, and then creates the shell.  This order needs to be adjusted to make sense.

PW

Comment 1 Missing name Mising name

2014-04-01 13:16:38 EDT

Hi Paul,

which listener exactly do you mean?

Regards
  René

Comment 2 Paul Webster

2014-04-01 13:29:43 EDT

I was questioning the order of operations in org.eclipse.ui.internal.quickaccess.SearchField.createWidget(Composite, MApplication, MWindow)

add a listener to the parent shell, restore the dialog, create our own shell.

But I'm not so sure that it's a problem now.

PW

Comment 3 Missing name Mising name

2014-04-01 13:53:08 EDT

(In reply to Paul Webster from comment #2)
> I was questioning the order of operations in
> org.eclipse.ui.internal.quickaccess.SearchField.createWidget(Composite,
> MApplication, MWindow)
> 
> add a listener to the parent shell, restore the dialog, create our own shell.
> 
> But I'm not so sure that it's a problem now.
> 
> PW

The order of restore the dialog and create our own shell is totally fine because the restoreDialog() method just reads preferences which are afterwards needed to create the shell. Maybe it's name could be a little bit better (e.g.: loadDialogSettings())

The listener which is added to the parent shell could be moved to the end of the createWidget() method but this doesn't change anything in it's behavior, because it only uses member variables of the SearchField class.

If you want I can change this as described above.

René

Comment 4 Eclipse Genie

2020-03-27 08:48:13 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.