| Summary: | splitter - editor on left hand side tracking selection during splitter move (Chrome) | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | libingw, Silenio_Quarti |
| Version: | 1.0 | ||
| Target Milestone: | 2.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Susan McCourt
This is visible in the compare page on Chrome. What's weird is that it doesn't happen in the git status page in the nested compare editors. It seems the browser is still performing its selection. I believe the splitter needs to stop the mouse down event in Sppliter._mouseDown to prevent this.
_mouseDown: function(event) {
if (event.target === this._thumb) {
return this._thumbDown(event);
}
if (this._tracking) {
return;
}
this._node.classList.add("splitTracking"); //$NON-NLS-0$
this._mainNode.classList.add("panelTracking"); //$NON-NLS-0$
this._sideNode.classList.add("panelTracking"); //$NON-NLS-0$
this._tracking = this._mouseMove.bind(this);
window.addEventListener("mousemove", this._tracking); //$NON-NLS-0$
lib.stop(event); // ADD THIS LINE
},
thanks, Silenio. I checked mousemove and forgot mousedown! |