Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 398410

Summary: Remove deprecated OSGi Support
Product: z_Archived Reporter: Shaun Smith <shaun.smith>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: edwin.tang, eric.gwin
Version: unspecifiedFlags: eric.gwin: documentation+
eric.gwin: kepler+
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Shaun Smith CLA 2013-01-17 10:28:40 EST
EclipseLink JPA's OSGi support was deprecated in 2.2.0 (Feb. 2011) and should be removed as sufficient time (2 years) has gone by for existing users to have transitioned to Gemini JPA.  Newcomers continue to post questions on the use of the deprecated "native" OSGi support because they see the bundles in the EclipseLink distribution.  I have updated all the wiki example pages to point to the Gemini JPA project which should help set developers on the right track.  The next step is removal from future releases.
Comment 1 Eric Gwin CLA 2013-02-05 10:37:30 EST
The simplest initial steps would include not building or shipping the bundles. It is a very easy thing to stop shipping them. Removing them from the build is a logical next step and is also fairly simple. 

I just need to know exactly what to stop shipping/building.
are we talking the o.e.p.osgi bundle? Tom mentioned equinox and weaving, so I want to verify. 

I believe our current default is Gemini is it not? Removing the code linkage to the deprecated OSGi support is something Tom would need to do however.
Comment 2 Eric Gwin CLA 2013-02-06 11:34:03 EST
After speaking with Peter, then Tom it looks like the o.e.p.jpa.osgi, o.e.p.jpa.equinox, and o.e.p.equinox.weaving jars need to be removed from the build. 

So as a first step, I am removing those three jars from the build, our P2 features, install bundles, eclipselink.jar, and our maven publishing.
Comment 3 Eric Gwin CLA 2013-02-06 14:06:33 EST
removed o.e.p.jpa.osgi, o.e.p.jpa.equinox, o.e.p.jpa.equinox.weaving from build, PublishToMaven, and P2 generation.

Also removed unnecessary definitions associated with them.

Also had to exclude: 
org.eclipse.persistence.testing.tests.jpa.deployment.CompositeEnumerationTest
and comment out references to it in
org.eclipse.persistence.testing.tests.jpa.FullRegressionTestSuite

in order for the jpa.test build to complete successfully.
Comment 4 Eric Gwin CLA 2013-02-06 14:07:37 EST
After tonight's build the code can be removed from the repository.
Comment 5 Eric Gwin CLA 2013-02-07 13:07:01 EST
The Nightly QA matrix has failures as a result. eclipselink.osgi.test can either be adapted to Gemini or removed from the nightly testing entirely (I don't know that adapting makes any sense as I'd assume that similar tests are already run for our Gemini support). 

Full removal will need to wait until QA can remove the test execution from the nightly automation scripts.
Comment 6 Edwin Tang CLA 2013-02-11 14:53:29 EST
Just made a change on the automation scripts. Now the nightly testing does not execute the OSGi tests anymore.
Comment 7 Eric Gwin CLA 2013-03-27 13:06:58 EDT
2.5.0 no longer ships or builds the bundles, but the code is still in the repo. Should it be removed before closing this bug?
Comment 8 Eric Gwin CLA 2013-03-27 13:24:35 EDT
closing as I have opened bug# 404478 to track removal of the code from the codebase.
Comment 9 Eclipse Webmaster CLA 2022-06-09 10:21:11 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink