Bug 398403

Description John Gymer 2013-01-17 10:14:19 EST

The size of a RAP Table appears to be calculated incorrectly - all RAP Tables appear to be 10 pixels too tall, which happens to also be the height of the horizontal scroll bar in the default theme.

Using RAP 2.0 M4 with some Nightlies, but don't think this has changed for a while.

Example snippet below, but here's a summary... let's say I want a Table whose overall size is 200x200, so I use table.ComputeTrim(0,0,200,200) to work out what actual size I'll end up with. Under RAP with default theme I'm getting 212x202, so I adjust the size I request with my FormData object i.e. 188x198.

However, on doing this the overall size always ends up 10 pixels too tall, as if it is not talking into account the height of the hscrollbar. Whether the hscrollbar exists or not is irrelevant - it still appears to use its height in the calculation somehow.

Here's an example, which happens to have a header and hscrollbar, but these can be removed and the effect is the same...


package bug.snippet;

import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Color;
import org.eclipse.swt.graphics.RGB;
import org.eclipse.swt.graphics.Rectangle;
import org.eclipse.swt.layout.FormAttachment;
import org.eclipse.swt.layout.FormData;
import org.eclipse.swt.layout.FormLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.ScrollBar;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Table;
import org.eclipse.swt.widgets.TableColumn;

public class Bugsy {
	private static Display display;
	private static Shell shell;
	private static Table tab;
	private static Button but;
	private static TableColumn col;
	
	public static void main(String args[]) {
		System.out.println("BugSnippy Starting...");
		
		// create Shell1
		display = new Display();
		shell = new Shell(display, SWT.TITLE|SWT.MAX|SWT.MIN|SWT.RESIZE|SWT.CLOSE);
		shell.setText("Shell");
		shell.setSize(300, 300);
		shell.setLocation(20, 20);
		shell.setBackground(new Color(null, new RGB(255,128,128)));
		FormLayout layout = new FormLayout();
		shell.setLayout(layout);

		//create the table
		tab = new Table(shell, SWT.FULL_SELECTION|SWT.BORDER);
		tab.setHeaderVisible(true);
		tab.setLinesVisible(true);

		int myTableHeight = 200;
		int myTableWidth = 200;

		System.out.println("Desired overall table size = " + myTableWidth + " x " + myTableHeight);
		Rectangle trimRect = tab.computeTrim(0, 0, myTableWidth, myTableHeight);
		System.out.println("TrimRect if I simlpy used that size = " + trimRect.width + " x " + trimRect.height);
		myTableWidth -= trimRect.width - myTableWidth;
		myTableHeight -= trimRect.height - myTableHeight;
		System.out.println("Size needs to be (adjusted by trim minus desired) = " + myTableWidth + " x " + myTableHeight);

		col = new TableColumn(tab, SWT.NONE);
		col.setResizable(true);
		col.setWidth(500);
		col.setText("My Column");

		ScrollBar hScrollBar = tab.getHorizontalBar();

		//set table's position
		FormData fd = new FormData();
		fd.left = new FormAttachment(0, 5);
		fd.top = new FormAttachment(0, 5);
		fd.width = myTableWidth;
		fd.height = myTableHeight;
		tab.setLayoutData(fd);

		// add a button just below the lower edge of where the table should end
		but = new Button(shell, SWT.BORDER|SWT.PUSH);
		but.setText("Below Table Button");
		fd = new FormData();
		fd.left = new FormAttachment(0, 5);
		fd.top = new FormAttachment(0, 205);
		fd.width = 200;
		fd.height = 24;
		but.setLayoutData(fd);
		
		shell.open();
		System.out.println("Actual Table size = " + tab.getSize().x + " x " + tab.getSize().y);
		if (hScrollBar != null) {
			System.out.println("HScrollBar height = " + hScrollBar.getSize().y);
		}

		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
		
		System.out.println("BugSnippy Done!");
	}

}


This technique to adjust the Table size based on ComputeTrim() works perfectly under SWT - I get my Button placed immediately below the bottom edge of the Table, but under RAP the Table covers the top 10 pixels of the Button.

RAP EntryPoint is a simple one like this:


package bug.snippet;

import org.eclipse.rap.rwt.application.EntryPoint;

public class RAPEntryPoint_BugSnip implements EntryPoint {
	@Override
	public int createUI() {
		System.out.println("Starting RAP");
		Bugsy.main(null);
		System.out.println("RAP Done");

		return(0);
	}
}