Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 398392

Summary:	Inactive icon does not show up in main toolbar
Product:	[Eclipse Project] Platform	Reporter:	Richard Birenheide <richard.birenheide>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.2.1
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Richard Birenheide

2013-01-17 09:00:24 EST

When contributing a command to the main toolbar using the org.eclipse.ui.menus extension point, the inactive icon maintained does not show up, when the handler is inactive or not enabled. Instead, a greyed version of the active icon is displayed. As that one is rather ugly for my contribution I use an own one.

When contributing via actionSet, this works.

The respective section of my plugin.xml is below:

 <menuContribution
            allPopups="false"
            locationURI="toolbar:org.eclipse.ui.main.toolbar?after=additions">
         <toolbar
               id="com.sap.test.team.br.toolbar.pushBack"
               label="ABAP Team">
            <command
                  commandId="com.sap.test.team.br.command.pushBackAll"
                  disabledIcon="icons/inactive/checkin.png"
                  icon="icons/active/checkin.png"
                  id="com.sap.test.team.br.toolbar.mainPushBack"
                  label="PB"
                  style="pulldown"
                  tooltip="Push last to Backend">
               <parameter
                     name="com.sap.test.team.br.pushBack.pushLastDestination"
                     value="true">
               </parameter>
               <visibleWhen
                     checkEnabled="false">
                  <with
                        variable="activeWorkbenchWindow.activePerspective">
                     <or>
                        <equals
                              value="org.eclipse.jdt.ui.JavaPerspective">
                        </equals>
                        <equals
                              value="org.eclipse.jst.j2ee.J2EEPerspective">
                        </equals>
                     </or>
                  </with>
               </visibleWhen>
            </command>
            <command
                  commandId="com.sap.test.team.br.command.pushBack"
                  disabledIcon="icons/inactive/checkin.png"
                  icon="icons/active/checkin.png"
                  id="com.sap.test.team.br.toolbar.selectedPushBack"
                  label="PB"
                  mnemonic="com.sap.test.team.br.toolbar.selectedPushBack"
                  style="push"
                  tooltip="Push selected component">
               <visibleWhen
                     checkEnabled="false">
                  <with
                        variable="activeWorkbenchWindow.activePerspective">
                     <or>
                        <equals
                              value="org.eclipse.jdt.ui.JavaPerspective">
                        </equals>
                        <equals
                              value="org.eclipse.jst.j2ee.J2EEPerspective">
                        </equals>
                     </or>
                  </with>
               </visibleWhen>
            </command>
         </toolbar>
      </menuContribution>

Comment 1 Paul Webster

2013-01-17 10:02:32 EST


*** This bug has been marked as a duplicate of bug 384056 ***