Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397890

Summary:	Lots of pages reference settings.css
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, Mike_Wilson, susan, Szymon.Brandys
Version:	2.0
Target Milestone:	2.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-01-10 12:00:39 EST

Many pages are relying on settings.css to pick up certain styles. This makes it error-prone to modify to the settings page, as some internal-seeming CSS classes affect other pages.

The generally-applicable rules of settings.css should be identified and moved into a more reusable CSS file (like ide.css or sections.css).

Here are some details from Bug 397848 Comment 2 showing which classes are being used (note this is just for Git pages -- other pages may depend on different classes from settings.css).

settings.css
> html                  Line 7
> body                  Line 7
> select                Line 17
> .toolbarTarget:focus  Line 55
> ul                    Line 83
> .sectionProgress      Line 127
> .stretch              Line 315

Comment 1 Susan McCourt

2013-01-10 12:13:59 EST

I checked references to settings.css

It is mostly git, so assigning this bug to Szymon.

Besides git:
Mark, can you take care of sites.css since you are in there now anyway?
user-profile had a reference, but it wasn't needed so I removed it in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b23ef92fd4da0aa9bdc42bd24fede77b9ac8f100

It "would be nice" get this cleaned up for M2, but understood if we can't.

I think that the section related stuff should be copied to sections.css (stretch, sectionProgress, etc.).  Not sure about toolbarTarget:focus????

I would be dangerous I think to move html tag markup (html, body, select) to sections.  It should either be in theme.css or else become part of the page's individual css (or git css I suppose).

I think it's not good practice for common modules to define tag-based markup because then a page's basic styles can change underneath it as soon as you pull in some new common UI module.  Seems to me that stuff belongs in theme.css (and we already have tag based definitions there).

It would be risky to move classes to theme.css but in the short run we could move element based markup to the page css that needs it.

Comment 2 Szymon Brandys

2013-01-28 05:32:37 EST

Fixed with 0b903658298889c330826166415093d7262b2f19.