Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397888

Summary:

Unused type parameter problem should also depend on option to consider @param tag

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Manoj N Palat <manoj.palat>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jarthana, srikanth_sankaran

Version:

4.3

Flags:

srikanth_sankaran: review+

Target Milestone:

4.3 M5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

392946

Attachments:

Description	Flags
Fix for UI	none
Fix for JDT Core - Work In Progess.	none
Patch for JDT Core	none
Patch for JDT Core	none

Description Markus Keller

2013-01-10 11:43:50 EST

Created attachment 225460 [details]
Fix for UI

Follow-up to bug 385780

The JavaCore.COMPILER_PB_UNUSED_TYPE_PARAMETER option should also depend on COMPILER_PB_UNUSED_PARAMETER_INCLUDE_DOC_COMMENT_REFERENCE. I don't think it makes sense to add a separate sub-option.

Comment 1 Jay Arthanareeswaran

2013-01-10 11:51:46 EST

Manoj, please take a look

Comment 2 Markus Keller

2013-01-11 08:16:46 EST

The quick fix from bug 392946 already assumes this dependency.

Comment 3 Manoj N Palat

2013-01-14 23:25:34 EST

Created attachment 225599 [details]
Fix for JDT Core - Work In Progess.

This is a working solution.  [Patch marked as "work in progress" primarily because of checking out an optimization wherein a reduced set of @param tags only needs to be processed eliminating those tags which have been run-through resolveParamTags and resolved successfully to a param (rather than a type)].

Comment 4 Manoj N Palat

2013-01-15 19:42:26 EST

Created attachment 225665 [details]
Patch for JDT Core

Comment 5 Srikanth Sankaran

2013-01-16 01:12:15 EST

Comments:

1. I don't think we need the loop at all. At the place where the type parameter
is resolved from the @param tag, we should be able to mark it used.

2. @param for classes should be enclosed in <>

Comment 6 Manoj N Palat

2013-01-17 14:20:19 EST

Created attachment 225788 [details]
Patch for JDT Core

Comment 7 Srikanth Sankaran

2013-01-18 01:04:26 EST

Released via http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=d7b760eb9cb9581492e34768b7dc48857b9b10e4

Comment 8 Markus Keller

2013-01-21 07:16:44 EST

(In reply to comment #0)
> Created attachment 225460 [details] [diff]
> Fix for UI

Released as http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=b69e448521f6beccdaa711e78f6a3d43f46fc27f

Comment 9 Jay Arthanareeswaran

2013-01-21 23:15:17 EST

(In reply to comment #7)
> Released via
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=d7b760eb9cb9581492e34768b7dc48857b9b10e4

The commit note doesn't include the bug summary. It helps to have it there when someone is looking at the history. Please remember to include it next time on.