Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397848

Summary:	Git pages "shrunk" to 800px
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys
Version:	2.0
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Malgorzata Janczarska

2013-01-10 07:30:07 EST

Somewhere around commit e2250a33eceaf1cc61e05b6eb1804ce834e1cfc2 git pages display at maximum width 800px, that looks a little strange on bigger displays. I suspect the problem is in settings.css, where maximum width has been set to 800px in "settings" class.

Comment 1 Mark Macdonald

2013-01-10 10:39:50 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=30977da7205ff00024a72cde84828fd7d1911c53

Hmm. The max-width:800px was supposed to apply only to the settings page, but I forgot that Git pages also depend on on settings.css.

I moved the rules expected by Git into a "gitPanel" class, which is used instead of "settings" class. The Git pages look normal now.

Comment 2 Mark Macdonald

2013-01-10 10:52:34 EST

Also, the dependency of Git pages on settings.css kind of surprised me. I used a tool [1] to show which rules the Git pages are using from that file. Here is what I found:

settings.css
> html                  Line 7
> body                  Line 7
> select                Line 17
> .toolbarTarget:focus  Line 55
> ul                    Line 83
> .sectionProgress      Line 127
> .stretch              Line 315

If these are generally applicable, then they should get moved to a re-usable CSS file (perhaps sections.css???)

[1] https://addons.mozilla.org/en-US/firefox/addon/dust-me-selectors/