Bugzilla – Full Text Bug Listing
| Summary: | TAU JAXB workflow for ETFw | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Chris Navarro <cmnavarr> | ||||||||||||
| Component: | ETFw | Assignee: | Chris Navarro <cmnavarr> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | beth | ||||||||||||
| Version: | unspecified | ||||||||||||||
| Target Milestone: | 7.0 | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | All | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Bug Depends on: | 397684, 399550 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Navarro
Created attachment 227098 [details]
projects for tau-jaxb in new etfw framework
Created attachment 227099 [details] projects for tau-jaxb in new etfw framework I didn't see a way to obsolete the previous attachments after I forgot to check the box so here is another attempt. All patches for the framework are done in bug 397684 since all PTP patches were just x-friends. Chris, can you make the same statements for this bug? Thanks. 1. I authored 100% of the content I'm contributing 2. I have the rights to contribute the content to Eclipse 3. I contribute the content under the EPL' Also, please update the patch to address same issues for bug 397684 comment 10. I will make those changes. One other thing, I need to x-friend a package in org.eclipse.ptp.etfw for the plugin org.eclipse.ptp.etfw.tau.ui; however, I already have changes in my workspace to org.eclipse.ptp.etfw for bug 402787 (ETFw preference). If there are no objections, I will include the x-friend as part of 402787 patch since the discouraged access for the one class won't break anything. Unless you have another suggestion on how to do it. (In reply to comment #4) > Also, please update the patch to address same issues for bug 397684 comment > 10. Created attachment 228311 [details]
new projects for ETFw TAU Jaxb
Created attachment 228312 [details]
patches ptp projects for tau contribution
1) I have authored 100% of the content I am contributing 2) I have the rights to contribute the content to Eclipse 3) I contribute the content under the EPL. (In reply to comment #3) > Chris, can you make the same statements for this bug? Thanks. > > 1. I authored 100% of the content I'm contributing > 2. I have the rights to contribute the content to Eclipse > 3. I contribute the content under the EPL' Great, thanks. This has been approved also. Eclipse legal have asked that files you've derived from existing PTP work (e.g. ptp/etfw/tau/ui/TAUMakefileCombo.java) retain the original copyright header, if different from the current one. I'll go ahead and commit these, but if you could go through the files and make sure this is updated, it would be appreciated. Just attach a patch to this bug. For the example you mentioned, TAUMakefileCombo, the original class didn't list a copyright. This might be something Wyatt needs to address because there are a handful of other ETFw/TAU classes that are missing headers. Once you commit my patches, I'll fix the classes that do have copyrights so my derived classes retain the original and I'll email Wyatt to see if he can take a look at other classes that are missing copyrights. Committed to master. (In reply to comment #10) > Once you commit my patches, I'll fix the classes that do have copyrights so my > derived classes retain the original and I'll email Wyatt to see if he can take a > look at other classes that are missing copyrights. That'd be great. Thanks! Chris, rather than introduce two new plugins, would you have any objections if I moved the etfw.jaxb.contrib xml files to the etfw.tau.ui plugin (or should perfsuite fo somewhere else)? Note that ppw is no longer included in the PTP build, so I'll remove this altogether. Thanks. Actually, probably the org.eclipse.ptp.etfw.tau plugin would make more sense. I was trying to follow the pattern of the target configs (not really sure how many performance tools there will be), but perhaps to limit new plugins you can move the tau xml as you suggested (to etfw.tau.ui since it has custom widgets) and maybe tools like perfsuite which require no custom widgets can go into a new folder (contrib) inside the etfw.jaxb plugin. In the future all new tools that don't require custom widgets could just go in the etfw.jax contrib folder. Also, I've tested out the commits from this bug and everything looks to be working as expected. I've contacted Wyatt and he will update the class copyrights and once that is done I'll attach patches to address that. Ok, I've moved the files. Let me know if I've broken anything. I also took the liberty of moving schemas to the 'schemas' folders and renamed the 'toolsxml' folder to 'data' for consistency. Two things that I've noticed: 1) The ETFWCoreConstants.java wasn't updated to point at the new folder where the etfw_tool_type.xsd schema is located. It's still pointing at data/etfw_tool_type.xsd so it can't find the schema to unmarshall the xml. 2) The plugin.xml for org.eclipse.ptp.etfw.jaxb needs to add the extension "org.eclipse.ptp.etfw.jaxb.workflows" and create a new extension that points at the perfsuite-tool.xml. #1 should be fixed now. What is the workflow in #2 used for? Is it a replacement for an old type workflow? Persuite is another profiling tool (open source, developed at NCSA) that I messed around with while working on the ETFw framework. The original developer never got it working with the previous ETFw so Jay had me take a look at it while I was working on the transition to JAXB. More details here: http://perfsuite.ncsa.illinois.edu/ Cool. Can you open a separate bug and attach the file? I want to make sure you get the credit. fixed - committed to master |