Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397679

Summary:	Can't check out a file from Git Repo page
Product:	[ECD] Orion	Reporter:	Anton McConville <antonm>
Component:	Git	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys
Version:	unspecified
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Anton McConville

2013-01-08 09:49:36 EST

Can't check out ( discard ) files. When I push the button to check out, nothing happens. Similarly the merge and rebase buttons seemed unresponsive too.

Comment 1 Szymon Brandys

2013-01-08 10:15:20 EST

Anything in the console?

Comment 2 Anton McConville

2013-01-08 10:38:45 EST

(In reply to comment #1)
> Anything in the console?

No, nothing :( 

Susan saw the same thing when I talked to her yesterday ... sorry - I intended to make this bug yesterday, but got caught up in a couple of things.

Comment 3 Szymon Brandys

2013-01-08 10:40:11 EST

I see it too and nothing in the console.

Comment 4 Szymon Brandys

2013-01-08 10:46:57 EST

It is a bug introduced while fixing bug 395260. I fixed something similar today in the ReviewContribution command.

See gitCommands.js line 2899
var deferred = progress.progress(serviceRegistry.getService("orion.git.provider"), messages['Resetting local changes']).checkoutPath(data.userData.Clone.Location, paths); //$NON-NLS-0$

Should be 
var deferred = progress.progress(serviceRegistry.getService("orion.git.provider").checkoutPath....,  messages['Resetting local changes'])

Moving to Gosia.

Comment 5 Anton McConville

2013-01-08 11:18:19 EST

(In reply to comment #4)
> It is a bug introduced while fixing bug 395260. I fixed something similar
> today in the ReviewContribution command.
> 
> See gitCommands.js line 2899
> var deferred =
> progress.progress(serviceRegistry.getService("orion.git.provider"),
> messages['Resetting local
> changes']).checkoutPath(data.userData.Clone.Location, paths); //$NON-NLS-0$
> 
> Should be 
> var deferred =
> progress.progress(serviceRegistry.getService("orion.git.provider").
> checkoutPath....,  messages['Resetting local changes'])
> 
> Moving to Gosia.

Thanks for looking into it.

Comment 6 Malgorzata Janczarska

2013-01-08 12:08:48 EST

I found and corrected problems in those commands:
* check out
* rebase
* reset
* unstage
I did not find the problem in merge, seems to work fine. Please verify and if it's still broken reopen the bug.