| Summary: | Problem with sequence of dialogs | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | susan |
| Version: | 0.2 | ||
| Target Milestone: | 2.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e50b14a2e13956bc6375f0dc0f3733c2f57b6c20 The queries were too broad and picking the first dialog on the page vs. the one you are in. |
Look at gitCommands.js around line 1494. I create RemotePrompterDialog which is passed as a param to a confirmation dialog. So the confirmation dialog is displayed first and then if you click More you will get RemotePrompterDialog. It used to work well before moving orion/webui/dialog. I see a problem with dialog lifecycle here. Look at RemotePrompterDialog.js and you will see RemotePrompterDialog.prototype._beforeShowing = function() { // Start the dialog initialization. this._initialize(); this._loadRemoteChildren(); }; If I call _initialize in constructor and do anything in _bindToDom, it is added to the confirmation dialog instead of RemotePrompterDialog.