Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397670

Summary: Problem with sequence of dialogs
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: susan
Version: 0.2   
Target Milestone: 2.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Szymon Brandys CLA 2013-01-08 07:22:17 EST
Look at gitCommands.js around line 1494. I create RemotePrompterDialog which is passed as a param to a confirmation dialog. So the confirmation dialog is displayed first and then if you click More you will get RemotePrompterDialog. It used to work well before moving orion/webui/dialog.

I see a problem with dialog lifecycle here. Look at RemotePrompterDialog.js and you will see

RemotePrompterDialog.prototype._beforeShowing = function() {
	// Start the dialog initialization.
	this._initialize();
	this._loadRemoteChildren();
};

If I call _initialize in constructor and do anything in _bindToDom, it is added to the confirmation dialog instead of RemotePrompterDialog.
Comment 1 Susan McCourt CLA 2013-01-09 10:28:39 EST
Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e50b14a2e13956bc6375f0dc0f3733c2f57b6c20

The queries were too broad and picking the first dialog on the page vs. the one you are in.