Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397480

Summary:	[compare] - Compare with each other command doesn't work for two .txt files
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw
Version:	1.0
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2013-01-04 16:26:28 EST

I removed some methods from compareUtils in order to get the navigator to load without dojo/dijit.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=faf57df79e7c769cbc6421b01e6682f75c620d39

In testing that I hadn't broken the compare link generation in the navigator, I noticed that you can't compare two text files with each other.  This is because the command checks to see if the two files in question are extensions of "text/plain" but doesn't check if they *are* text/plain

Comment 1 libing wang

2013-01-07 10:26:42 EST

Good catch, Susan.
I've changed 4 places where a text file needs to be verified:
1.Compare two files command.
2.CTRL+SHIFT+F command, where the decision is made to open a file with edit.html or not.
3.Crawler, where it needs to know all the text files for both global key word search and tree compare.
4.Advanced search, where all the text file types are listed up.

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3b5113fa22e28a6b5c44a89cfe10e59e7c6dc46d