Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 397397

Summary:	commonHTML fragments should use NLS string binding
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2013-01-03 13:25:14 EST

This is really a code readability issue vs. any real problem.
When we made the pass to get rid of inlined message strings in NLS catalogs, we did so by creating text nodes and then concatenating safe innerHTML strings into the fragment.  

I think it would be more readable if we used the data binding approach used in dialog templates.

Comment 1 Susan McCourt

2013-01-04 13:21:22 EST

fixed in 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2836a38acb023333a459fd87222b24c863cc5f1d

This exercise also unearthed some untranslated strings in the aria attributes and tooltips.  Fixed those as well.  Also cleaned up all the "non-nls" warnings in globalCommands.

Comment 2 Susan McCourt

2013-01-29 11:23:14 EST

In RC1 I've moved the various fragments into HTML files for easier recognition/editing.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b56a6a57d23572039a84ef2f1aa96b8da60ff98f