Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 396817

Summary:	Compare view stopped working
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	libingw, susan
Version:	1.0
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Szymon Brandys

2012-12-18 05:16:09 EST

I can't open Compare View. Opening a page with url like https://orion.eclipse.org/compare/compare.html?readonly#/gitapi/diff/7c337cf3688b3cf6052b8d936c54542efd96c883..09cef3b1c3dd055908586fc7ac5982d6c8a37ae1/file/L/org.eclipse.orion.client/modules/orionode/build/build.js,block=1

ends up with

TypeError: c.DeferredList is not a constructor
https://orion.eclipse.org/compare/built-compare.js
Line 3256

Gosia sees the same problem locally.

Comment 1 libing wang

2012-12-18 10:17:19 EST

Investigating now

Comment 2 Susan McCourt

2012-12-18 10:56:01 EST

Libing, it's possible that compare view never declared a dependency on DeferredList even though it used it.  Back when modules like globalCommands used it, they got it anyway.  Now that much of core doesn't use it, you won't get it for free anymore.  

Instead you want to use Deferred.all(...

see 

http://wiki.eclipse.org/index.php?title=Orion/Library_Independence#General_JavaScript_utilities

Comment 3 libing wang

2012-12-18 11:06:06 EST

(In reply to comment #2)
> Libing, it's possible that compare view never declared a dependency on
> DeferredList even though it used it.  Back when modules like globalCommands
> used it, they got it anyway.  Now that much of core doesn't use it, you
> won't get it for free anymore.  
> 
> Instead you want to use Deferred.all(...
> 
> see 
> 
> http://wiki.eclipse.org/index.php?title=Orion/
> Library_Independence#General_JavaScript_utilities

Yes, Susan. I will go over and refactor them.

Comment 4 libing wang

2012-12-18 14:38:14 EST

fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=688ffd3076860311cc6d149561d16912ba620329.
Talked to Susan for hte quick fix on deferred list. I did not refactor the dojo.DeferredList but just add require on that.
There are other reasons causing the comapre page failed as well.
Eventually we will remove dojo completely together with other dojo UI stuff.