Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 396188

Summary:	Problem with popup dialogs when trying to focus on the input field
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	antonm, ken_walker, malgorzata.tomczyk, susan
Version:	1.0
Target Milestone:	2.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Szymon Brandys

2012-12-10 09:15:11 EST

Steps:
1) Go to the repository view
2) Go to the conf section and try to edit any value (click the pencil)
3) In my case a slideout is open, but the value field does not have focus
4) When I click the input to get the focus, the slideout is closed

Comment 1 Ken Walker

2012-12-10 09:28:28 EST

I immediately get focus so can start typing but if I click into the field it goes away. And you have to click on another pencil to get it back.


Seems fine on OrionHub.org

Comment 2 Susan McCourt

2012-12-10 11:58:31 EST

the bug says slideout but you are speaking of the tooltip dialog, right?

Comment 3 Susan McCourt

2012-12-10 12:00:18 EST

Happens for all tooltip dialogs, such as "create new HTML5 project" etc.

Comment 4 Ken Walker

2012-12-10 12:42:43 EST

This is looking worse from a first user perspective.  Both the fact that if you click, it's gone and also that the colour is not right.

Susan looking into it and Anton can you look at the colours?

Comment 5 Susan McCourt

2012-12-10 13:06:15 EST

I pushed a fix for the click problem.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b3e403a5ef8e086f13572de17ad4965c57dbed0e

There are several styling problems:

1) text is light gray/hard to read on white
2) no borders on the text fields

The problem is in this commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0616eed490d4a3044abd5ea43ade73e3988aca56

The styles for all input fields in Orion were updated to remove borders and use light text.  I think the intention was only to change it for the new dark slideouts.

Comment 6 Susan McCourt

2012-12-10 13:10:31 EST

We need to either:
- establish a special class for things that appear in dark slideouts.  We can't use the "parameter" classes because they are used in both tooltip popup dialogs and in slideouts.  Before, the same colors could be used but with the dark slideouts, they don't share color attributes anymore.

- if we thought dark dialogs were the direction going forward, we could instead try to style the popup dialogs so that they were dark, too.  I just worry about us understanding the impact of that decision in the short time frame.

Comment 7 Ken Walker

2012-12-10 13:20:33 EST

This needs to be fixed for M1

Comment 8 Susan McCourt

2012-12-10 15:32:58 EST

the popups have class "parameterPopup" so I think we can fix the labels/borders there locally by doing something like this:  (colors are just a hack/proof of concept)

.parameterPopup > label {
	color: red !important;
}

.parameterPopup > input {
	border: 1px solid orange !important;
	color: green !important;
}

This fixes the borders and colors without affecting slideouts.

I'm still not sure if we want to keep the 
input
style with no border or not.

Comment 9 Susan McCourt

2012-12-13 12:37:40 EST

Anton pushed the visual parts for M1.
Closing bug.