Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 396068

Summary: modular banner behavior (globalCommands is a wad)
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 1.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Susan McCourt CLA 2012-12-07 12:55:46 EST 
Our banner is created by taking a document fragment (defined in commonHTMLFragments.js) and then adding behavior to various DOM elements in globalCommands.js.

However globalCommands has grown over time to include "any and all common behavior that a page may want to have."  As such the file is a big wad of different concerns, and as we add richer common behavior (good) the wad grows (bad).

We should have a way of registering common behavior somewhere and adding it on the fly rather than having all the code in globalCommands.  Note that a plugin is not quite the right answer, because much of the work done is in-page.  It's as if we want to register an in-page service and then iterate over them.
Comment 1 John Arthorne CLA 2015-05-05 15:48:39 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 2 John Arthorne CLA 2015-05-05 16:01:50 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html