Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 395994

Summary: [generalize type] Generalize Declared Type ignores use of a variable in foreach loop
Product: [Eclipse Project] JDT Reporter: Milos Gligoric <milos.gligoric>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: manju656
Version: 4.2.1   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug

Description Milos Gligoric CLA 2012-12-06 17:13:39 EST
Steps to reproduce:
1. See the instructions in code below
2. The resulting code does not compile ("Can only iterate over an array or an instance of java.lang.Iterable")

class GeneralizeDeclaredTypeBug7 {
    // Invoke "Generalize Declared Type" on "List"
    // and select "Object" as new type
    List list;

    void f() {
        for (Object o : list)
            ;
    }
}

Result:

class GeneralizeDeclaredTypeBug7 {
    Object list;

    void f() {
        // Error is on the next line: "Can only iterate over an array or an instance of java.lang.Iterable"
        for (Object o : list)
            ;
    }
}

(Thanks to Yilong Li for helping with the bug report.)
Comment 1 Martin Mathew CLA 2012-12-18 00:43:10 EST
Issue is reproducible using I20121210-0800. The refactoring results in compiler error.
Comment 2 Eclipse Genie CLA 2020-03-03 17:19:30 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.