Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 395824

Summary:	Work flow to handle code review and contribution from git hub pull request.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ahunter.eclipse, pwebster, Szymon.Brandys
Version:	1.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2012-12-05 10:19:15 EST

I have a case that the contributor asked a pull request but without bothering http://wiki.eclipse.org/Orion/Contributing_Code#Request_adoption_of_your_changes.

The commit of the pull request look like: https://github.com/anaran/orion.client/commit/d613ef951669349afb0544493c3e661f53149d54.

I had a hard time to follow the steps in our wiki http://wiki.eclipse.org/Orion/Contributing_Code#Accepting_a_contribution. But after talking to Szymon I was kind of able to craft a review URL and managed to merge the contributor's code to my master. I will doc this in the wiki as the work around but Szymon and I agree that we should extend the review request to support this case.

Comment 1 libing wang

2012-12-05 12:27:14 EST

Added wiki doc http://wiki.eclipse.org/Orion/Contributing_Code#Variation_1:_accepting_a_contribution_from_git_hub_pull_request.

Comment 2 Anthony Hunter

2015-05-08 13:40:19 EDT

(In reply to libing wang from comment #1)
> Added wiki doc
> http://wiki.eclipse.org/Orion/Contributing_Code#Variation_1:
> _accepting_a_contribution_from_git_hub_pull_request.