Bugzilla – Full Text Bug Listing
| Summary: | Remote request for Japanese search term does not return correct result set | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Soveran <yxzhong> | ||||||
| Component: | User Assistance | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ChrisAustin, curtis.windatt.public, pwebster | ||||||
| Version: | 3.4.2 | Keywords: | helpwanted | ||||||
| Target Milestone: | 4.3 M5 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Soveran
As far as I can tell, you haven't described an issue with Eclipse. The search functionality on info center is returning different results based on the url you are searching from? Closing as NOT_ECLIPSE. If this is a problem with the eclipse help system, please reopen and explain where the issue might be. Unfortunately there are no active user assistance committers to ask. (In reply to comment #1) > As far as I can tell, you haven't described an issue with Eclipse. The > search functionality on info center is returning different results based on > the url you are searching from? > > Closing as NOT_ECLIPSE. If this is a problem with the eclipse help system, > please reopen and explain where the issue might be. Unfortunately there are > no active user assistance committers to ask. The issue is that by using URL ” http://pic.dhe.ibm.com/infocenter/rhaphlp/v8/search?phrase=ドメイン&lang=ja“ should return the same result with User directly search "ドメイン" in "Search” field which will get 29 hits according to User's saying. This functionality does relate to the Help System, as far as I can tell. The problem here is that an Eclipse client can connect to other infocenters using Window -> Preferences -> Help -> Content. When a user performs a search in the Eclipse client, Eclipse has to check each remote connection stored in the above preferences to see if the search has any hits on the remote infocenters. The URL eclipse uses to perform the remote searching is the help/search?phrase=x URL. No one is watching this component at the moment. We would consider a patch if supplied. PW Yeah I am looking at it now, I can commit a patch if I figure it out (and if I remember how to use git) Created attachment 224582 [details]
Patch to remove unnessary decode() call.
OK, it looks like there is an unnecessary call to URLCoder.decode() in SearchServlet.java:
phrase = URLCoder.decode(phrase);
The decode method creates a new decoded String in UTF-8, which works fine when searching in en, but creates a corrupted String in other locales like ja. I have done some additional testing, and it looks like the text is already passed in decoded, both in the ja and en cases. I have tested a variety of special characters, and they are all passed in unencoded.
Removing the call to URLCoder.decode() allows the correct result set to be returned. I have created a patch for this issue - since I am a little rusty on my committing, is there anything else that needs to happen before I (or someone else) commits this fix for 4.3?
That line showed up during bug 122967 originally. PW (In reply to comment #6) > > Removing the call to URLCoder.decode() allows the correct result set to be > returned. I have created a patch for this issue - since I am a little rusty > on my committing, is there anything else that needs to happen before I (or > someone else) commits this fix for 4.3? We're in 4.3M4 this week, so you can go ahead and commit it to master on Monday. PW (In reply to comment #6) > Created attachment 224582 [details] > Patch to remove unnessary decode() call. OK, master is open. PW Committed to master, closing. seems like this patch doesn't work for IE8, did you get a chance to check that? is there any fix you can provide? |