Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 395099

Summary:

eclipse-junit-tests needs to include the latest test scripts

Product:

[Technology] CBI

Reporter:

Paul Webster <pwebster>

Component:

prototype

Assignee:

CBI Dummy user <cbi.prototype-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bugs.eclipse.org, david_williams, thanh.ha

Version:

1.0

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

372792

Attachments:

Description	Flags
junit.patch	none
junit.patch v2	none

Description Paul Webster

2012-11-26 13:49:45 EST

The test scripts included in the junit zip need to be updated to the latest scripts:

CBI:
eclipse-junit-tests-v20120913-1603.zip  readme.html*   test.properties
equinoxp2tests.properties               runtests*      test.xml*
finalPluginsVersions.properties         runtests.bat*
label.properties                        runtests.sh*


M20121121-1200:
eclipse-junit-tests-M20121121-1200.zip    runtests
equinoxp2tests.properties                 runtests.bat
finalPluginsVersions.properties           runtestsmac.sh
label.properties                          runtests.sh
org.eclipse.jdt.doc.isv.javadoc.txt       testframework.html
org.eclipse.pde.doc.user.javadoc.txt      test.properties
org.eclipse.platform.doc.isv.javadoc.txt  test.xml
readme.html


The 3 .txt files are size '0'

PW

Comment 1 David Williams

2012-11-26 19:19:18 EST

I'd like to ask, "are you sure"? 

And, I know you are right ... but ... I've always found this "test package" to be a bit awkwardly designed. I know in the interest of "getting things the same" we could just keep doing what we are doing ... but, if you see ways to simplify, I wouldn't complain. For example, during our production tests, we actually use the "runtests*" files from eclispebuilder (but I know committers, and others use those in this zip, which packages up the ones from eclipsebuilder). As another, I'm sure you know, finalPluginsVersions.properties actually comes from the PDE build output. Not sure where that's to some from in CBI build? 

I know you (nor I) are in a position to "redesign" all this at the moment, just wanted to add a word of caution. Long term, I'd see an "eclipseTester" project that currently does what's partially in eclipsebuilder, and partially in the test zip package. 

Just FYI, FWIW.

Comment 2 Thanh Ha

2012-11-27 22:01:11 EST

Created attachment 224029 [details]
junit.patch

Attached patch updates the eclipse-junit-tests scripts with the latest from eclipsebuilder. I'm not sure where the 3 *.txt files come from however so they are not included...

Also the the junit tests produced by the patch has not been tested yet... I'll try to test it in the near future.

Comment 3 Thanh Ha

2012-11-30 09:46:04 EST

Created attachment 224155 [details]
junit.patch v2

Updated to include the scripts from master

Comment 4 Thanh Ha

2012-12-03 10:01:39 EST

I pushed the patch to R4_2_maintenance.

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=2bfda35891e69cb1e140f8d2b811541eb90bd3c5

Comment 5 Thanh Ha

2013-07-31 10:55:15 EDT

I think we can resolve this now. We should open a new bug for any remaining items.