Bugzilla – Full Text Bug Listing
| Summary: | eclipse-junit-tests generates incorrect label.properties file | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] CBI | Reporter: | Paul Webster <pwebster> | ||||||
| Component: | prototype | Assignee: | CBI Dummy user <cbi.prototype-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | thanh.ha | ||||||
| Version: | 1.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 372792 | ||||||||
| Attachments: |
|
||||||||
Also, equinoxp2tests.properties also seems to use the somewhat outdated buildQualifier: v20120913-1603
That should also be the ${buildId}, M20121126-1034
PW
Created attachment 224017 [details]
junit.tests.patch
Attached patch modifies the listed files to use ${buildId} instead of ${buildQualifier}.
I changed the buildType to M in label.properties but I'm not sure if this is the correct thing to do. How does PDE handle this parameter?
With Maven/Tycho I don't think there's a way to substring ${buildId} to grab just the first character. A workaround would be to add an additional parameter to set this via commandline input.
(In reply to comment #2) > Created attachment 224017 [details] > junit.tests.patch thanks Thanh, Yes, we might have to provide a buildType in eclipse-parent, we can default it to M or I depending on the stream. PW (In reply to comment #3) > (In reply to comment #2) > > Created attachment 224017 [details] > > junit.tests.patch > > Yes, we might have to provide a buildType in eclipse-parent, we can default > it to M or I depending on the stream. Ok I'll update the patch to add a buildType. Created attachment 224019 [details]
junit.tests.patch v2
Updated patch to set a ${buildType} parameter in eclipse-parent and use that instead for the buildType.
I pushed this into 4.2.2 and 3.8.2 branches 4.2.2: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=7e1785d8fbc2867e00195d50847623917a38f6d6 3.8.2: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R3_8_maintenance&id=b1a4b82e7be034518b3b0f39e4df3b44c95d144e |
eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests During the build, eclipse-junit-tests seems have a very old build qualifier and some static content. ex: current build: timestamp=v20120913-1603 buildType=I buildId=v20120913-1603 buildLabel=v20120913-1603 What it should look like (ignore the huge indent :-) timestamp=201211211200 buildType=M buildId=M20121121-1200 buildLabel=M20121121-1200 We have a ${buildId} defined now in the eclipse parent, even that would be an improvement PW