Bugzilla – Full Text Bug Listing
| Summary: | remove "icu.base" from Eclipse DL site to avoid redundancy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | David Williams <david_williams> | ||||||
| Component: | Build | Assignee: | David Williams <david_williams> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | aniefer, curtis.windatt.public, daniel_megert, john.arthorne, pascal, tjwatson | ||||||
| Version: | 4.2 | ||||||||
| Target Milestone: | 4.3 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 395003 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
David Williams
Created attachment 223933 [details]
patch to remove requirement for icu.base bundle
Attaching patch just to be explicit.
I noticed once I tried to remove icu.base from every where else, it was still being included in repository (during test builds) so I removed from map file, and sure enough, the build failed, at this point.
Just to dwell on this a bit, we currently do not provide this "product" from download page -- as far as I can tell. We do provide "pde sdk", but that is entirely based on org.eclipse.pde feature. And that depends on platform and jdt. If someone wanted to "make" or "install" this pde product, say from repo, it would be hard to do without the full icu. So, I think its "inclusion" in the product definition was a good idea, but ... probably an old one, when PDE was active? Just getting started with ICU4J? I think its a valid question if this PDE "product" should still be being built. But, I could easily be missing the point of it, and would appreciate the education if there is a reason for it. I have sent an email off to the PDE Dev list suggesting that we remove the product from the build. If it is not available on the download page, that is a good indication that no one is using it. David, when you have time, please look into removing it from the build process entirely. By then I will hopefully have commit rights to PDE Build and can help clean up the files in PDE Build. (In reply to comment #3) > I have sent an email off to the PDE Dev list suggesting that we remove the > product from the build. If it is not available on the download page, that > is a good indication that no one is using it. > > David, when you have time, please look into removing it from the build > process entirely. By then I will hopefully have commit rights to PDE Build > and can help clean up the files in PDE Build. I removed it from the build, and did a small test build to make sure nothing blew up ... and nothing did. I found it odd that this product feature, org.eclipse.pde.build.product.feature, was being pulled in to the build by the master-equinox feature. Hence, I've added Tom to this bug, in case there was some special use-case or history he remembered. (I hadn't even thought to look on equinox DL page, but ... not there either). (In reply to comment #4) > I found it odd that this product feature, > org.eclipse.pde.build.product.feature, was being pulled in to the build by > the master-equinox feature. Hence, I've added Tom to this bug, in case there > was some special use-case or history he remembered. (I hadn't even thought > to look on equinox DL page, but ... not there either). This was something that Jeff McAffer wanted. See bug 327966, and bug 330240. (In reply to comment #5) > (In reply to comment #4) > This was something that Jeff McAffer wanted. See bug 327966, and bug 330240. Thanks Andrew. That makes it clearer this was something just left over. We've since changed those plans. Just to document it here, I'm also removing this feature, org.eclipse.pde.build.product.feature, from the 3.8 and 4.2 builds as well. I could not find it in any repos or anything so pretty sure no one would have had an accidental dependency on it. I recommend the feature project in PDE be "nulled out" from master, though, so its clearer to those browsing the repo it is no longer active. So will leave this bug open ... even though main issue has been solved. Ping David, (In reply to comment #6) > I recommend the feature project in PDE be "nulled out" from master, though, > so its clearer to those browsing the repo it is no longer active. So will > leave this bug open ... even though main issue has been solved. Created attachment 228598 [details]
patch to remove product feature from master branch and repo pom
Not sure why you were pinging me except that my comment about "nulling it out" must have been unclear. So, hopefully this patch clears it up ... remove all files except .project and an added readme.
And, very important, remove from the "modules" section of the "repository pom".
This patch is again the whole repo, imported into workpace as one "general project".
Hope this helps,
(In reply to comment #8) > Not sure why you were pinging me except that my comment about "nulling it > out" must have been unclear. So, hopefully this patch clears it up ... > remove all files except .project and an added readme. Sorry, thought you were still planning to remove it from some build script. I've deleted all the files and added the readme from your patch. http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=ea1307e74badce9e846aa560d3a2f565b21762ef No additional concerns about the product have been brought forward. Marking as verified in I20130428-2000 |