| Summary: | Incorrect drag event shown on file upload | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mike Milinkovich <mike.milinkovich> | ||||
| Component: | Client | Assignee: | Susan McCourt <susan> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 1.0 | ||||||
| Target Milestone: | 2.0 M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
depending on the browser you were on... it could be a FF bug (https://bugzilla.mozilla.org/show_bug.cgi?id=484511), or it's possible that our import file D&D is not using the event to update the effects. Hmmm.... The code to set the drop effect to "copy" was not in master, yet I know I tested (and blogged about it) in http://adventuresinthoughtlessness.blogspot.com/2012/11/dropping-into-orion-html5-drag-and-drop.html That's disturbing, something must have hiccupped on the push. At any rate, the import dialog was not using the same "dropEffects" API to set the action to copy. So I've fixed both the navigator and the import dialog, but it only works properly on Chrome. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=06ab58645f9b537132cadcb0a4421701ee22dd95 |
Created attachment 223926 [details] Screenshot of drag event on file upload When dragging and dropping a file from Windows Explorer onto the "Upload local file..." dialogue, Windows 7 is showing the "Move" event. However, when you drop the file there, it is actually copied. I tried <shift>drag and <ctrl> drag, and they all behaved the same way. Please see attached screen shot.