Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 394427

Summary: org.eclipse.pde.build.internal.tests.p2.P2Tests.testP2SimpleProduct() test failure
Product: [Eclipse Project] PDE Reporter: Curtis Windatt <curtis.windatt.public>
Component: BuildAssignee: John Arthorne <john.arthorne>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, Michael_Rennie
Version: 4.3   
Target Milestone: 4.3 M4   
Hardware: Macintosh   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=299776
Whiteboard:
Bug Depends on:    
Bug Blocks: 398434    
Attachments:
Description Flags
Fix for the tests none

Description Curtis Windatt CLA 2012-11-15 16:56:55 EST 
expected:<0> but was:<1>

junit.framework.AssertionFailedError: expected:<0> but was:<1>
at org.eclipse.pde.build.internal.tests.p2.P2TestCase.getIU(P2TestCase.java:170)
at org.eclipse.pde.build.internal.tests.p2.P2TestCase.getIU(P2TestCase.java:160)
at org.eclipse.pde.build.internal.tests.p2.P2Tests.testP2SimpleProduct(P2Tests.java:97)
at org.eclipse.pde.build.tests.PDETestCase.runTest(PDETestCase.java:61)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:655)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)

Needs to be debugged on the Mac.  The test is looking for a launcher IU, but there is custom code for the mac.  Perhaps this information is outdated.

String p2Config = ws + '.' + os + '.' + arch;
String launcherConfig = os.equals("macosx") ? ws + '.' + os : p2Config;
Comment 1 Curtis Windatt CLA 2012-11-16 13:17:49 EST 
A special case was added for Mac OS in Bug 299776.  This special case is no longer needed as the delta pack provides a fragment with the architecture to the p2 repo (org.eclipse.equinox.launcher.cocoa.macosx.x86_64).

Mike tested the change and the P2Tests pass.
Comment 2 Curtis Windatt CLA 2012-11-16 13:19:33 EST 
Created attachment 223668 [details]
Fix for the tests

As the ACL's haven't been changed yet, John please commmit the fix when you have the chance.
Comment 4 Curtis Windatt CLA 2012-12-11 14:53:42 EST 
Verified I20121210-2000