Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 394342

Summary:	[settings] Installing a non-plugin URL ending with ".js" fails with no UI feedback
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Simon Kaegi <simon_kaegi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	simon_kaegi
Version:	2.0
Target Milestone:	2.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2012-11-14 17:44:04 EST

1. Go to Settings > Plugins
2. Click Install, then paste this url into the url field:
  https://orion.eclipse.org/plugins/fileClientPlugin.js
(This URL is not a valid plugin and I expected it to fail)
3. Click Install.

A console error is generated:
> Uncaught Error: SECURITY_ERR: DOM Exception 18   pluginregistry.js:639

The page UI just says "Loading https://orion.eclipse.org/plugins/fileClientPlugin.js..." forever.

Comment 1 Simon Kaegi

2013-01-30 11:17:23 EST

It fails and I get a red load timeout message after 15s.

Load timeout for plugin: https://orion.eclipse.org/plugins/fileClientPlugin.js

Comment 2 Simon Kaegi

2013-01-30 11:38:35 EST

I just got the same DOM Exception 18 note and it indeed hangs

Comment 3 Simon Kaegi

2013-01-30 11:40:23 EST

The problem is that the js file is being interpreted as a Web worker however it is not in the same origin so throwing a dom exception...

Comment 4 Simon Kaegi

2013-01-30 14:36:03 EST

I've fixed this now and added a bit better error handling to differentiate between an error loading a page and a page failing to perform the plugin handshake. I've removed support for Web Worker plugins as these are not nearly as useful as I had originally hoped. Web Workers are of course still useful but should simply be created inside of the plugin instead of by the the plugin registry.