Bugzilla – Full Text Bug Listing
| Summary: | Update Eclipse 4 tools projects with HandlerProcessingAddon | ||
|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Marco Descher <marco> |
| Component: | UI | Assignee: | Nobody - feel free to take it <nobody> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Benjamin.Brandl, Lars.Vogel, nobody, tom.schindl |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 396249 | ||
|
Description
Marco Descher
Please use a more descriptive bug title, AFAIK this is about adding HandlerProcessingAddon in the Eclipse 4 wizard to a new project. I haven't thoroughly looked at the occurrences but I suppose there are other places which require attention (e.g. model editor itself like in the linked forum post etc) . The idea is that I will do a thorough search and remove for any processHierarchy references and anywhere there are the "default" addons I will add the handler addon. @Marco, you messed up the forum post. The correct one is http://www.eclipse.org/forums/index.php/t/437480/ Pushed fix in topic branch because I have to wait for M4 for the addon to be available on platform. If I commit to master and people get the latest tools build they would get CNF Exception because they have to have the HandlerProcessingAddon present (unless they have the latest master of platform/ui). http://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?h=smcela/HandlerAddonUpdates&id=c20a38791112a4359f4d40e5494df5874ac41d5b The addon is only in 4.3M4 so what you need to do is to check if your target is 4.2.x or 4.3 and only add the addon if you are on 4.3M4! @Tom see Bug 396249 IMHO this here is a bit different. Bug 396249 talks about tooling compile time dependencies of the tooling where as here the project wizard needs to differentiate between 4.2.x and 4.3 runtimes, so it needs to check the runtime-bundles (e.g. the e4.ui.workbench) and decided upon this version if it should add the new addon or not! I think we should simply offer a version for Eclipse 4.2 and another for Eclipse 4.3. as suggested in Bug 396249. I would like to avoid the runtime check, I assume there will be other non-compliant changes in the Eclipse 4.3 platform. We moved with master to Eclipse 4.3. development, hence I cherry-picked Sopots commit into master with: http://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=4410818c0837262bc9abfd937ad912441ae78c8c |