Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 394079

Summary: [Theming][List] Custom variant styling for lines in List do not work correctly
Product: [RT] RAP Reporter: Steffen Eichenberg <steffen.eichenberg>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 1.5   
Target Milestone: 2.0 M4   
Hardware: PC   
OS: Windows 7   
Whiteboard: sr152
Attachments:
Description Flags
Example List to show effect
none
patch for 1.5 ivan: review+, rsternberg: review+

Description Steffen Eichenberg CLA 2012-11-12 06:07:46 EST
Created attachment 223448 [details]
Example List to show effect

For the regular variant of a list widget the theming works just fine.

For a custom variant, the background color of a list item is only used for the initial lines in a list. When adding lines later to the list, they do not get the color of the variant but of the standard theming instead.
Comment 1 Tim Buschtoens CLA 2012-11-13 08:40:27 EST
Fixed with commit e865b3667958e8a6d5793e9b9097ddee304e3aff.

I will attach a patch for the 1.5 branch soon.
Comment 2 Tim Buschtoens CLA 2012-11-13 09:52:18 EST
Created attachment 223513 [details]
patch for 1.5
Comment 3 Ivan Furnadjiev CLA 2012-11-13 09:59:21 EST
Comment on attachment 223513 [details]
patch for 1.5

+1 patch looks good to me.
Comment 4 Ralf Sternberg CLA 2012-11-13 12:12:52 EST
Comment on attachment 223513 [details]
patch for 1.5

+1 for the 1.5 patch
Comment 5 Tim Buschtoens CLA 2012-11-15 05:05:10 EST
Pushed to streams/1.5-maintenance branch.
commit 262a4b6eda5c7b3d681391267aa2c95adcbcb396