| Summary: | Problem hover - Link text cut at end for some OSes / fonts | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | John Koumarelas <John.Koumarel> | ||||||||||||
| Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> | ||||||||||||
| Status: | CLOSED NOT_ECLIPSE | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | daniel_megert, i-lite, james+eclipse, ljelinek, markus.kell.r, Sergei.Vatshekin, shr31223 | ||||||||||||
| Version: | 4.2.1 | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
This is expected. The hover shows the error/warning along with the possible quick fixes for that problem. Ctrl+1 shows the Quick Fixes plus Quick Assists which are not related to the error/warning. Hence Ctrl+1 can show more entries. (In reply to comment #1) > This is expected. The hover shows the error/warning along with the possible > quick fixes for that problem. Ctrl+1 shows the Quick Fixes plus Quick > Assists which are not related to the error/warning. Hence Ctrl+1 can show > more entries. Dani it is my fault, I didn't explain it correctly. The "sentences" are not completed fully. e.g. Instead of showing: import 'IOException' (java.io) it only shows import There are several packages where this happens, and it not only happens in imports, but on "create class", "change to" etc. The sentences/phrases are not completed. When I press ctrl-1 the same sentences that were not completed in the combined hover, are fine. ...so it's not completed yet. (changing status to REOPENED) To be even more precise, if you look at the attachment picture: You can look at the following mapping: (ctrl+1 --> combined hover) Create class 'IOException' --> Create class Change to 'IndirectionException' --> Change to Change to 'InvalidKeyException' (java.security) --> Change to Change to 'InvalidKeyException' (javax.management.openmbean) --> Change to What is your dialog font (Preferences > Appearance > Colors and Fonts)? . Created attachment 223223 [details]
Dialog font
Actually I played with a different font Daniel and the problem disappeared! We're close...
Created attachment 223224 [details]
Problem across font families
After a bit of experimenting, the problem seems a bit weird. The (DejaVu) Sans and (DejaVu) Serif fonts are problematic but the (DejaVu) monospace are not. (All monospace fonts show correct entries/sentences.
We should not use WRAP style when creating our links. I've fixed that in http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ce590e50a4d315a2ad4d37a7a3899361e7fed928 However, on my Ubuntu box those fonts render correctly, so I suspect that your fonts are not correct and hence we get wrong font metrics. Moving to SWT for comment. Can you attach one of the font files for further investigation? Created attachment 223233 [details]
Font Files
Attached Fonts: DejaVu Sans, Serif and Mono (Monospace must be SansMono file).
Thank you for your help!
*** Bug 396458 has been marked as a duplicate of this bug. *** *** Bug 406978 has been marked as a duplicate of this bug. *** *** Bug 412665 has been marked as a duplicate of this bug. *** *** Bug 412021 has been marked as a duplicate of this bug. *** I found bug 151322 and bug 169698 about the same problem in Link#computeSize(). I've released a workaround in JDT Text (master for 4.4) that will make the full label visible when the hover is wide enough: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=74d3083d8b588e19d7f3591440137762008d2487 *** Bug 420872 has been marked as a duplicate of this bug. *** Created attachment 237128 [details]
Ubuntu (13.10) Font
Eclipse on Ubuntu uses the above font at size 11. Is this still reproducible with latest version? |
Created attachment 223196 [details] Combined hover - values missing and ctrl-1 hover - everything is ok Hello, I have Arch Linux x64, KDE. The problem that appeared is that when I hover over a problem, e.g. a class that isn't imported, the combined hover appears but some values are not present. If I press ctrl+1, everything appears fine. This happens to: "import", "create class", "change to" etc. I attach an example (2 pictures)