Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 393391

Summary: [Contributions] can't re-enable toolbars in "customize perspective"
Product: [Eclipse Project] Platform Reporter: Whitehat Whitehat <i>
Component: UIAssignee: Andrey Loskutov <loskutov>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: egil, Lars.Vogel, loskutov, mariusz, michael.schneider3, noopur_gupta, p.bodnar, pwebster
Version: 4.2.1   
Target Milestone: 4.5 M5   
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 180308, 420956    
Attachments:
Description Flags
Lost toolbars none

Description Whitehat Whitehat CLA 2012-11-02 05:03:27 EDT 
Tested on clean "install" (unzip) eclipse-jee-juno-SR1-linux-gtk-x86_64 on ubuntu 12.10 and eclipse-java-juno-SR1-win32 on Windows XP sp3.
Launch eclipse, switch to Java perspective.
go to "window->customize perspective"
disable some toolbars, press "OK"
Toolbars dissaeper, as it should be.
Now go to "window->customize perspective". There we can see, that recently disabled toolbars are marked as enabled. Disabling and enabling them once more doesn't help - toolbars remain hidden, while in setting they are enabled.
Other problem -  I disable toolbar in Java perspective, save that perspective, then switch to debug perspective - toolbars, that have been disabled in Java perspective, are also disabled in Debug perspective, and there is no way to re-enable them.
Comment 1 Whitehat Whitehat CLA 2012-11-02 05:04:13 EDT 
Created attachment 223097 [details]
Lost toolbars
Comment 2 Whitehat Whitehat CLA 2012-11-02 05:18:29 EDT 
After Eclipse restart all the toolbars are back. But there is still no way to disable a toolbar in one perspective and leave it visible in other...
Comment 3 Whitehat Whitehat CLA 2012-11-02 11:57:32 EDT 
Ok. Got it. To make enabled toolbars visible - I have to fully restart Eclipse after each perspective change
Comment 4 Evgeniy Gil CLA 2013-08-16 01:14:02 EDT 
Problem disappears if commented code 
		// legacyWindow.getMenuManager().updateAll(true);
		// ((ICoolBarManager2) ((WorkbenchWindow)
		// getWorkbenchWindow()).getCoolBarManager2())
		// .resetItemOrder();
in WorkbenchPage.resetPerspective() method will be uncommented
Comment 5 Petr Bodnar CLA 2013-10-28 08:04:44 EDT 
Seeing the same issues with KEPLER 4.3.1 on Ubuntu 12.04.

To sum it up, there are 2 problems:

1. (citing) "There we can see, that recently disabled toolbars are marked as enabled."

This is confusing as one doesn't see the real state in the Customize Perspective dialog. Unchecking and checking a selected toolbar action seems to cause a change.

2. (citing) "But there is still no way to disable a toolbar in one perspective and leave it visible in other"

It really seems like enabling / disabling toolbar in one perspective causes changes in another perspective (which it shouldn't). To reproduce:

a. Hide the "Search" actions from toolbar in the Java perspective.
b. (optional step) Switch to the Synchronize perspective. The "Search" actions are hidden here as well.
c. In the Customize Perspective dialog uncheck & check one of the "Search" actions (or all of them, but you must do it one by one).
d. Now the newly checked actions are visible in BOTH (or even ALL) perspectives.

---

So maybe there are several problems (not sure about the problem with the "need to fully restart Eclipse...") described in here? Open a new bug for some of these?

BTW Severity of this bug increases in combination with the bug 362420 (=> toolbar area will render two rows instead of one). Luckily, I prefer keyboard shortcuts, so I can hide nearly all the toolbar buttons in whichever perspective they are... :)
Comment 6 Andrey Loskutov CLA 2013-11-03 05:31:20 EST 
Related to bug 383569 and bug 395601 and bug 404009 and bug 404348 and bug 407522 and many other bugs... I've created bug 420956 as overview...
Comment 7 Lars Vogel CLA 2015-01-26 09:28:06 EST 
(In reply to Andrey Loskutov from comment #6)
> Related to bug 383569 and bug 395601 and bug 404009 and bug 404348 and bug
> 407522 and many other bugs... I've created bug 420956 as overview...

Andrey, it this on your working list? I tested it with the change in https://git.eclipse.org/r/#/c/40354/ in Build id: N20150124-1500 but I cannot re-enable a disabled command. It ge the following error message:

"Print (Ctrl+P)" cannot be made visible because it is in the unavailable "null" action set.
Comment 8 Andrey Loskutov CLA 2015-01-26 09:37:28 EST 
(In reply to Lars Vogel from comment #7)
> Andrey, it this on your working list? 

This is working with latest nightly build.

> I tested it with the change in
> https://git.eclipse.org/r/#/c/40354/ in Build id: N20150124-1500 but I
> cannot re-enable a disabled command. It ge the following error message:
> 
> "Print (Ctrl+P)" cannot be made visible because it is in the unavailable
> "null" action set.

This is something different. I can disable and reenable the print button without mentioned patch on exact same build.
Comment 9 Lars Vogel CLA 2015-01-26 11:53:00 EST 
(In reply to Andrey Loskutov from comment #8)

> This is something different. I can disable and reenable the print button
> without mentioned patch on exact same build.

I agree, the existing buttons can be re-enabled. Marking as fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1d3294204c71b0cd1e7e2e831feb2faf6133ec38
Comment 10 Noopur Gupta CLA 2015-01-27 08:55:02 EST 
Verified as fixed in 4.5.0.I20150126-2000.
Comment 11 Andrey Loskutov CLA 2015-02-07 17:54:56 EST 
*** Bug 421178 has been marked as a duplicate of this bug. ***