Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 393269

Summary:	[GTK] Slider Selection events do not have detail field set
Product:	[Eclipse Project] Platform	Reporter:	Grant Gayed <grant_gayed>
Component:	SWT	Assignee:	Eric Williams <ericwill>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	chandrayya.gk, ericwill, pmatveev42
Version:	4.2	Keywords:	triaged
Target Milestone:	4.14 M1
Hardware:	PC
OS:	Linux-GTK
See Also:	https://git.eclipse.org/r/149427 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3604d504487ba5ac6629a7341338d0fa513e8af0
Whiteboard:
Bug Depends on:	510538
Bug Blocks:

Description Grant Gayed

2012-10-31 12:23:24 EDT

4.3M3 test build
- works fine for 32-bit
- Snippet17 shows the problem

The CHANGE_VALUE signal comes in to Widget.windowProc(), but its user_data contains garbage, so the Slider's gtk_change_value() method is never invoked.  I think that one problem here is that this signal is being hooked in Display to windowProc5, however according to http://developer.gnome.org/gtk/2.24/GtkRange.html#GtkRange-change-value this signal has four parameters, not five (though why does it work fine in 32-bit?).  I changed it to windowProc4 instead, but user_data still contains garbage.  It looks as if the signal's "value" argument is being omitted.

Comment 1 Eric Williams

2018-04-13 16:29:10 EDT

Still reproducible on 4.8 M6, GTK3.22, Fedora 27.

Comment 2 Eric Williams

2019-03-29 07:45:12 EDT

The signal params for "change-value" have a double in it, which is causes the garbage input on top of the fact that the signal is using windowProc5 instead of windowProc4.

Comment 3 Eric Williams

2019-09-12 10:25:17 EDT

*** Bug 402732 has been marked as a duplicate of this bug. ***

Comment 4 Eclipse Genie

2019-09-13 13:19:16 EDT

Gerrit change https://git.eclipse.org/r/149427 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3604d504487ba5ac6629a7341338d0fa513e8af0

Comment 5 Eric Williams

2019-09-13 13:21:08 EDT

(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/149427 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=3604d504487ba5ac6629a7341338d0fa513e8af0

In master now.

Comment 6 Eric Williams

2019-10-08 13:30:32 EDT

Verified in I20191008-0600.